Giter Site home page Giter Site logo

Comments (3)

akarabashov avatar akarabashov commented on June 12, 2024

After discussion, it has become clear that the following actions are required to resolve the issue:

  • Validation Implementation: Add a validation to ensure that when CommissioningCustomFlow is set to 0, CommissioningModeInitialStepsHint must not be 0.
  • Data Migration: Correct previously created models where both CommissioningCustomFlow and CommissioningModeInitialStepsHint were set to zero.

from distributed-compliance-ledger.

ashcherbakov avatar ashcherbakov commented on June 12, 2024

Decisions on DCL TT call:

  • Starting 1.4, default will be 0, 1 (Power Cycle).
  • Make CommissioningModeInitialStepsHint mutable. Update the Spec.
  • The current wrong entries with 0,0 will be fixed by asking members to update this field for data after to 1.4 (once it's made mutable).

This will avoid complex migration and mutation of data which we should not do.

from distributed-compliance-ledger.

akarabashov avatar akarabashov commented on June 12, 2024

PR: #562

  • Functionality implemented as described in the task.
  • Unit and integration tests are added.
  • Docs are updated.

from distributed-compliance-ledger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.