Comments (3)
zizroc
commented on May 25, 2024
Re. 1. Yes, concur.
Re. 2. I see this for bugs. But what about upgrades? (I.e., very small code changes that are unlikely to break anything or result in bugs). Do those not usually become pull requests?
from villager.
ThomasThelen
commented on May 25, 2024
I'm totally fine with relaxing point 2. Everything should go through a pull request so that the continuous integration system (Travis) is able to verify that the package still builds, unit tests didn't break, etc.
Note on point 1: Time might be an issue, so I think if the PR is in for more than something like a week and it has at least one approval, it should get merged (we do this in one of my current projects). After a week, it gets hard to add features because of the potential merge conflicts, so to mediate giving an expiration should help.
from villager.
ThomasThelen
commented on May 25, 2024
More than less done
from villager.
Related Issues (20)
- Fix the Linter Warnings
- Tidy up the DESCRIPTION File HOT 1
- Increase Test Coverage of village_state and village HOT 1
- Write the code documentation HOT 1
- Look into List Copying
- Help Wanted: Code Review HOT 1
- Add support for variadic parameters in add_resource & add_winik
- Add support for user defined data writing HOT 1
- Add support for retrieving all of the resources in a resource manager HOT 1
- Check minimum dependencies HOT 1
- Add Community Guidelines HOT 1
- Run tests and code coverage with github actions HOT 1
- Replace the gregorian package HOT 2
- Add paper to new branch
- Add new badges HOT 1
- make a logo HOT 3
- Update license for JOSS HOT 3
- Some confusing conventions HOT 2
- Add a new example
- Update Paper HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from villager.