Add Basic Trade

[ThomasThelen]

Add Basic Trade

[ThomasThelen]

Just a quick note that the double for loop in the Simulation class will have to change. Right now it advances each village through time, independently. ie it runs village A for 10 years, then runs village B for 10 years when it should run village A for 1 year, then run village B for run year, then back to A, etc

[ThomasThelen]

After discussing it with Marcus, the trade was originally designed to be in a subclassed village. This is no longer the case, and trade is officially not supported at this moment.

We Currently Have

1. The ability to connect two villages for trade with add_trade_partner.
2. A skeleton method for executing trade algorithms, trade

We Don't Have

1. The ability to add custom functions that dictate trade behavior to the village
2. The logic that actually executes the trade (the contents of trade())

Adding Custom Functions

I think it makes the most sense to do this with add_trade_partner. This method becomes
add_trade_partner = function(newTradePartner, trade_model, addBack=TRUE). This ties a particular trade model to that village. By pairing the village to the algorithm (village, trade_algo) you can have different dynamics between villages.

The tuple should then be added so some sort of list that belongs in villager, like models.

Running the Trade Models

Once the models are stored, you'll want to run them at each time step. Note that the logic for whether it's a trading day (ie a festival) is in the trade model code.

I believe the trade() method in villager is there for historical reasons. This was the method that subclassed villages subclassed with their trade logic.

There are a couple of ways to do this.

Same way as propagate()

Loop over the trade functions and call them in the trade() method, and call village$trade() in the simulation class. If you put the call before the call to propagate, then the trade is done at the beginning of time step (day, month, year). If it goes after, then it's at the end of the year, month, day, etc.

Call from propagate

You can also put the logic in propagate(). You can also call trade() from propagate and skip the Simulator class

Which One?

There's a nice sense of division of responsibility in the first way. But the second way has a sense of elegance in that just a single call to the village propagates it through time. Your call!