Comments (4)
@dan-harris released Perfume.js v0.8.0
Grazie mille for your contribution 🙌
from perfume.js.
Thank you for opening this issue, and a PR it's more than welcome. 🔥🚀🌕
As you noticed, the solution seems to be divided into two steps:
-
remove
if (this.config.logging)
from
Line 117 in 3d3a201
-
Add the
this.config.logging
check inside thelog()
method
Line 140 in 3d3a201
We can land your fix with v0.8.0
from perfume.js.
Great, will shoot through a PR as soon as possible 👍
from perfume.js.
@dan-harris Great fix! It's going to land on v0.8.0 soon.
from perfume.js.
Related Issues (20)
- IE11 support HOT 2
- Uncaught TypeError in PerformanceObserver HOT 1
- ios 14 compatity issue, and element timing is not working HOT 1
- Is it supported in Safari? HOT 2
- How can I get a http api time? HOT 3
- Resource timings buffer extension HOT 1
- CLS calculation HOT 4
- Question about Interaction to Next Paint (INP) implementation HOT 20
- how use it for Wordpress sites HOT 2
- required member entryTypes is undefined HOT 2
- metric name "navigationTiming" data abnormal HOT 1
- web-vitals navigationType support HOT 5
- Disable requestIdleCallback for CLS and INP reports HOT 6
- TotalBlockingTime wrong reports HOT 2
- Cannot read properties of undefined (reading 'requestStart') on navigation with bfcache HOT 12
- Coinbase website Allowlist bug
- Soft Navigations support HOT 1
- Inaccurate (zero) size reported for some images
- v9.0.0 TS2305: Module '"perfume.js"' has no exported member 'Perfume'. HOT 2
- 0c0d611819dccfbdf82f48c67715e2a02f52e3fe
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from perfume.js.