zmarko/semver

Validating semantic versioning (semver) parser and comparator written in C++

semver's Issues

unused parameter ‘s’ - compile error when building library gcc version 8.3.0 (Debian 8.3.0-6)

If I understood cmake then I could probably silence this error, unless an unused variable is a bug?
Can you provide a fix for the code, or the cmake config? Thank you for your work on this library.

/home/grostig/src/semver_zmarko/semver/src/Semver200_modifier.cpp:53:67: error: unused parameter ‘s’ [-Werror=unused-parameter]

grostig@debian-x86-64:~/src/semver_zmarko/semver/build$ cmake ..
-- The C compiler identification is GNU 8.3.0
-- The CXX compiler identification is GNU 8.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/grostig/src/semver_zmarko/semver/build

grostig@debian-x86-64:~/src/semver_zmarko/semver/build$ make semver
Scanning dependencies of target semver
[ 25%] Building CXX object src/CMakeFiles/semver.dir/Semver200_comparator.cpp.o
[ 50%] Building CXX object src/CMakeFiles/semver.dir/Semver200_parser.cpp.o
[ 75%] Building CXX object src/CMakeFiles/semver.dir/Semver200_modifier.cpp.o
/home/grostig/src/semver_zmarko/semver/src/Semver200_modifier.cpp: In member function ‘version::Version_data version::Semver200_modifier::reset_major(const version::Version_data&, int) const’:
/home/grostig/src/semver_zmarko/semver/src/Semver200_modifier.cpp:53:67: error: unused parameter ‘s’ [-Werror=unused-parameter]
Version_data Semver200_modifier::reset_major(const Version_data& s, const int m) const {
~~~~~~~~~~~~~~~~~~~~^
cc1plus: all warnings being treated as errors
make[3]: *** [src/CMakeFiles/semver.dir/build.make:89: src/CMakeFiles/semver.dir/Semver200_modifier.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:91: src/CMakeFiles/semver.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:103: src/CMakeFiles/semver.dir/rule] Error 2
make: *** [Makefile:118: semver] Error 2

grostig@debian-x86-64:~/src/semver_zmarko/semver/build$ uname -a
Linux debian-x86-64 4.19.0-6-amd64 #1 SMP Debian 4.19.67-2+deb10u2 (2019-11-11) x86_64 GNU/Linux

grostig@debian-x86-64:~/src/semver_zmarko/semver/build$ c++ -v
Using built-in specs.
COLLECT_GCC=c++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/8/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Debian 8.3.0-6' --with-bugurl=file:///usr/share/doc/gcc-8/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++ --prefix=/usr --with-gcc-major-version-only --program-suffix=-8 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --enable-default-pie --with-system-zlib --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 8.3.0 (Debian 8.3.0-6)

Incrementing version

Hi Marko

Thanks for your work on semver cpp, Did you have any plans to increment/decrement a version by a specified level (major, minor patch etc..). Something akin to the -i --increment option in https://github.com/npm/node-semver