plot_pd: no geom_line-lines if predictor ordered factor

[stefanherzog]

plot_pd: no geom_line-lines if predictor ordered factor

[zmjones]

No that is a bug. There is a check somewhere in there for ordering that is apparently broken or somehow the ordered factor is being coerced to a unordered factor.

My computer has been kaput and being repaired until today and I'm a bit behind on other work, but I will get to this soon.

Thanks for the report and glad you like the package!

[stefanherzog]

Thanks for your thoughts on this!

[zmjones]

Totally forgot about this for a while, sorry.

So you are right: by default ggplot2 groups factors (including ordered ones). So even though geom_line is called it just prints the points. The alternative would be to coerce ordered factors to integers. I think then I can probably label the axis using the factor labels. Will work on this when I get a chance. Hopefully the whole thing is a bit more reliable now!

[stefanherzog]

Thanks!

[zmjones]

So I spent some time with this today and I think it makes sense to just do the easy thing here, which is to cast factors to integers, and draw lines if the factor was ordered. So your example should be fixed now. I don't see an easy way of adding the labels but I may revisit this at a later date when I have some more time. If you wanted to take a crack at it you are more than welcome to. I refactored and simplified things a good bit.

[stefanherzog]

Thanks so much! I tested it with my example above and it works nicely!