`hold-trigger-on-release` cancels effect of `hold-trigger-key-positions` with `flavor = "hold-preferred";`

[whxvd]

`hold-trigger-on-release` cancels effect of `hold-trigger-key-positions` with `flavor = "hold-preferred";`

[caksoylar]

The hold-trigger-on-release property was added to be used with the balanced flavor, and then augmented to work well with tap-preferred as well. I don't know if any special considerations are needed for it to work well with hold-preferred -- @urob do you have an idea?

Conceptually, if you add the on-release check then does hold-preferred flavor become equivalent to balanced? The difference seems to me thate the release of the interrupting key doesn't need to happen within the tapping term.

[urob]

Sorry for the late response. What would be the desired effect of setting hold-trigger-on-release with hold-preferred?

Doesn't hold-preferred trigger hold when another key is pressed? That's why I thought that when delaying the "positional check" until key release, it is effectively ignored (the hold-tap decision has already been made). If I am not missing something, I don't see a scenario where combining the two would make sense.

To prevent confusion, maybe we should just overwrite hold-trigger-on-release to be always false when the flavor is set to hold-preferred?

Re: tap-preferred, @celejewski wrote a patch to make the on-release option work with tap-preferred. I added it to my branch, but it's not in upstream zmk.

[whxvd]

What would be the desired effect of setting hold-trigger-on-release with hold-preferred?

I intended to try hold-preferred for home-row mod shift keys. At least for me, that can only reasonably work with hold-trigger-key-positions (left/right) and hold-trigger-on-release. The latter is necessary, because otherwise I cannot produce, e.g., Shift+Control together: Without hold-trigger-on-release, pressing the home-row keys for Shift and Control together immediately triggers the corresponding taps.

When I got the new keyboard and started to experiment with new layouts, I was awfully slow at typing. After having "recovered" to a large extend, it has become clear that hold-preferred almost certainly never will work for me on the home-row. So this issue is not an issue for me personally, anymore.

However, the bug that hold-trigger-on-release seems to cancel a hold-trigger-key-positions setting remains.

I am not 100% sure whether the originally desired effect of a hold-preferred home-row mod shift that can be combined with other home-row modifiers (of different flavor) is in principle possible / well-defined at all. In the case of hold-preferred, it may be necessary or desirable to have hold-trigger-on-release to also mean the release of the modifier, and not only the release of the modified key. But I don't know.