Comments (3)
The hold-trigger-on-release
property was added to be used with the balanced
flavor, and then augmented to work well with tap-preferred
as well. I don't know if any special considerations are needed for it to work well with hold-preferred
-- @urob do you have an idea?
Conceptually, if you add the on-release
check then does hold-preferred
flavor become equivalent to balanced
? The difference seems to me thate the release of the interrupting key doesn't need to happen within the tapping term.
from zmk.
Sorry for the late response. What would be the desired effect of setting hold-trigger-on-release
with hold-preferred
?
Doesn't hold-preferred
trigger hold when another key is pressed? That's why I thought that when delaying the "positional check" until key release, it is effectively ignored (the hold-tap decision has already been made). If I am not missing something, I don't see a scenario where combining the two would make sense.
To prevent confusion, maybe we should just overwrite hold-trigger-on-release
to be always false
when the flavor is set to hold-preferred
?
Re: tap-preferred
, @celejewski wrote a patch to make the on-release option work with tap-preferred
. I added it to my branch, but it's not in upstream zmk.
from zmk.
What would be the desired effect of setting
hold-trigger-on-release
withhold-preferred
?
I intended to try hold-preferred
for home-row mod shift keys. At least for me, that can only reasonably work with hold-trigger-key-positions
(left/right) and hold-trigger-on-release
. The latter is necessary, because otherwise I cannot produce, e.g., Shift+Control together: Without hold-trigger-on-release
, pressing the home-row keys for Shift and Control together immediately triggers the corresponding taps.
When I got the new keyboard and started to experiment with new layouts, I was awfully slow at typing. After having "recovered" to a large extend, it has become clear that hold-preferred
almost certainly never will work for me on the home-row. So this issue is not an issue for me personally, anymore.
However, the bug that hold-trigger-on-release
seems to cancel a hold-trigger-key-positions
setting remains.
I am not 100% sure whether the originally desired effect of a hold-preferred
home-row mod shift that can be combined with other home-row modifiers (of different flavor) is in principle possible / well-defined at all. In the case of hold-preferred
, it may be necessary or desirable to have hold-trigger-on-release
to also mean the release of the modifier, and not only the release of the modified key. But I don't know.
from zmk.
Related Issues (20)
- Error during build HOT 3
- Refactor sticky key and sticky layer doc pages to mention the underlying sticky key behavior
- Soft off only turn off the left side of my Corne split keyboard HOT 4
- How to toggle on and off behaviour (autoshift)? HOT 2
- Update development docs with new module instructions HOT 2
- Keys used in combos are not reflected with mouse clicks before timeout. HOT 1
- Hold-tap balanced flavor diagram: the 3rd drawing the same as the 2nd one
- caps word plus mods works only in some programms in Ubuntu HOT 4
- Sticky layer documentation is unclear HOT 2
- Getting constant battery indicator notifications on Linux. HOT 5
- TRRS, nice!nanos, and the corresponding issues could be improved
- Combine Layer-tap and To Layer HOT 1
- Soft off on the right side of Corne split keyboard issues HOT 4
- Encoder does not work if only on peripheral side
- Combos with `slow-release` produce error during build HOT 2
- Fully overlapping combos always trigger one with fewer numbers of keys HOT 1
- `hold-trigger-key-positions` does not seem to work with `flavor = "balanced"` HOT 3
- Cannot get nice!view to work after recent update HOT 4
- Combo + &mt => Combo wins HOT 3
- Inconsistent behavior when using &caps_word HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zmk.