Giter Site home page Giter Site logo

Comments (4)

zoltantothcom avatar zoltantothcom commented on May 27, 2024

It's weird because clampLines() with this.element is being called on componentDidMount() and a ref already should have been passed around according to React lifecycle diagram:

dz-97vzw4aabczj

from react-clamp-lines.

digigarlab avatar digigarlab commented on May 27, 2024

Regarding at the code, the only way I could see this happening is after a component unmount.

In the componentDidUnmount, the listener is removed, but there could be a debounced call still on the event loop at this stage, that would be executed after the component is actually unmounted.

From react doc:

React will assign the current property with the DOM element when the component mounts, and assign it back to null when it unmounts. ref updates happen before componentDidMount or componentDidUpdate lifecycle methods.

from react-clamp-lines.

digigarlab avatar digigarlab commented on May 27, 2024

I don't have much time to test that assumption right now, but assuming it is, the fix would be to either:

  • Ensure the component is still mounted before executing the func.apply in the debounced callback
  • Just check for this.element nullity in the clampLines function

from react-clamp-lines.

zoltantothcom avatar zoltantothcom commented on May 27, 2024

Thank you for your time and suggestion. This should be fixed now by

if (!this.element) return;

in clampLines()

from react-clamp-lines.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.