Giter Site home page Giter Site logo

Namespaced icons about react-components HOT 5 CLOSED

ubbe-xyz avatar ubbe-xyz commented on July 18, 2024
Namespaced icons

from react-components.

Comments (5)

ubbe-xyz avatar ubbe-xyz commented on July 18, 2024 1

@poteirard good point 👌🏻

We could do this as a first step?

Summarising pros and cons I can see from namepsacing:

Cons

  • Need to remember structure to use them
    • I guess TS integrations will hint to autocomplete with should make this less painful ?
  • <Icons /> by itself would render null I guess 😏

Pros

  • fewer imports ( as per the example above )
  • better readability ? ( <Icons.ZopaLogo /> vs <ZopaLogoIcon /> )

from react-components.

poteirard avatar poteirard commented on July 18, 2024 1

fewer imports ( as per the example above)

That's not 100% true you can always do import * as RC from 'react-components'; and then <RC.ZopaLogo />

from react-components.

thegrinder avatar thegrinder commented on July 18, 2024

I agree with @lluia, it does make it clearer and easier to import

from react-components.

poteirard avatar poteirard commented on July 18, 2024

What if we export the icons with
ProfileIcon instead then? I'm not a big fan of namespacing to be honest because you have to remember the structure/tree.

from react-components.

ubbe-xyz avatar ubbe-xyz commented on July 18, 2024

Addressed on 2.0 ☝️

from react-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.