JSON Marshalling of User Booleans Not Working Correctly

[zorkian]

JSON Marshalling of User Booleans Not Working Correctly

[zorkian]

It would be a breaking change, but as of right now this is broken and so we do need to do something. In #56 we were having a discussion about using pointers for optional fields. In this case IsAdmin and Disabled are both optional in the protocol, but Verified isn't (but we can't write that field).

So, I think converting those two to bool pointers would be reasonable, but as you mention does break the API. Let's discuss over on #56 what we'll do and then how to proceed.

[ojongerius]

@bflad AFAIC this is solved in https://github.com/zorkian/go-datadog-api/tree/v2 . Could you confirm this?

Are you ok with switching to v2 or do you prefer to have this solved in master (soon to become tagged with v1) too? If you absolutely want it fixed in master feel free to raise a PR with that destination.

[bflad]

I can take a look tomorrow, but was thinking it would require the changes in v2 to work properly and didn't spend time on a workaround. Thanks for the hard work with the pointers!

[ojongerius]

👍

[bflad]

Thanks for the Terraform PR as well, that was exactly my real use case! 💯

[ojongerius]

🎉