Comments (6)
It would be a breaking change, but as of right now this is broken and so we do need to do something. In #56 we were having a discussion about using pointers for optional fields. In this case IsAdmin and Disabled are both optional in the protocol, but Verified isn't (but we can't write that field).
So, I think converting those two to bool pointers would be reasonable, but as you mention does break the API. Let's discuss over on #56 what we'll do and then how to proceed.
from go-datadog-api.
@bflad AFAIC this is solved in https://github.com/zorkian/go-datadog-api/tree/v2 . Could you confirm this?
Are you ok with switching to v2 or do you prefer to have this solved in master (soon to become tagged with v1) too? If you absolutely want it fixed in master feel free to raise a PR with that destination.
from go-datadog-api.
I can take a look tomorrow, but was thinking it would require the changes in v2 to work properly and didn't spend time on a workaround. Thanks for the hard work with the pointers!
from go-datadog-api.
👍
from go-datadog-api.
Thanks for the Terraform PR as well, that was exactly my real use case! 💯
from go-datadog-api.
🎉
from go-datadog-api.
Related Issues (20)
- Adding a simple CLI utility that would expose functionality of this library HOT 1
- `GetIncludeTags()` defaults to `false` while API doc says the default is `true` HOT 1
- GetEvents() does not support the 'unaggregated' API argument HOT 1
- Help with PostMetrics HOT 1
- /v1/dashboard to get all dashboards is missing HOT 1
- Feature Request: Webhook Integration support HOT 4
- GetDashboard Fails Fatal When Scatterplot Exists in Dashboard HOT 5
- https://app.datadoghq.com/api/v1/validate endpoint returns HTML for non-valid api keys HOT 2
- Allow Retry Logic On Synthetics Tests HOT 1
- getDashboards and other operations use deprecated endpoints HOT 1
- Support for roles
- Is any plan to support "/v1/dashboard" API? HOT 2
- Allow for related_event_id on the Event struct
- [Feature request] Force deletion of monitors HOT 1
- Widget ID is too large for int
- ServiceLevelObjectiveHistory generates error during unmarshalling
- Log Stream Widget - Indexes
- Allow insecure certificates is not supported HOT 1
- GetMonitor does not support the group_states parameter HOT 1
- Any plans to add go.mod file HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-datadog-api.