DNS TXT record, on paste and save, is not the same result

[zpanel]

DNS TXT record, on paste and save, is not the same result

[stokes84]

Line 1001 of modules/dns_manager/code/controller.ext.php looks to be the culprit.

$data = strtolower($data);

Looks like line 1084 is where you'll see it being passed to the CleanRecord function. This can be fixed, good catch.

Yes dns should be case sensitive and this need to be fixed
Me.b

[allebb]

I'll implement a fix tomorrow... I'll add a conditional for TXT records as CNAME targets do look better as lowercase though!

Sent from my iPhone

On 13 Mar 2014, at 23:13, Me-Bl [email protected] wrote:

Yes dns should be case sensitive and this need to be fixed
Me.b

—
Reply to this email directly or view it on GitHub.

[didyouexpectthat]

I agree that CNAME targets look better as lowercase... However, when reading RFC 4343, DNS Case Insensitivity Clarification, section 4, I see that 'case MUST be preserved on output and preserved when convenient on input.' -- does this mean that case should not be modified in general when applying to DNS?

https://www.ietf.org/rfc/rfc4343.txt

Is the keyword "when convenient" the reason to force CNAME in lowercase?

[allebb]

I agree with what you are saying, what I mean't was and am saying is that i'm saying that i'll add a conditional sting to lower for CNAME records only! TXT record values will therefore remain untouched (unformatted) thus will ensure that it abides to the RFC.

Sent from my iPhone

On 13 Mar 2014, at 23:36, Cody Cook [email protected] wrote:

I agree that CNAME targets look better as lowercase... However, when reading RFC 4343, DNS Case Insensitivity Clarification, section 4, I see that 'case MUST be preserved on output and preserved when convenience on input.' -- does this mean that case should not be modified in general when applying to DNS?

https://www.ietf.org/rfc/rfc4343.txt

—
Reply to this email directly or view it on GitHub.

[didyouexpectthat]

I see. Thanks for the clarification. 👍
This will help me out tremendously as I have a lot of domains with TXT records. Thanks again.

[allebb]

This has now been fixed and latest version can be seen in this commit: 6e51c5e