Comments (7)
Line 1001 of modules/dns_manager/code/controller.ext.php
looks to be the culprit.
$data = strtolower($data);
Looks like line 1084 is where you'll see it being passed to the CleanRecord
function. This can be fixed, good catch.
from zpanelx.
Yes dns should be case sensitive and this need to be fixed
Me.b
from zpanelx.
I'll implement a fix tomorrow... I'll add a conditional for TXT records as CNAME targets do look better as lowercase though!
Sent from my iPhone
On 13 Mar 2014, at 23:13, Me-Bl [email protected] wrote:
Yes dns should be case sensitive and this need to be fixed
Me.b—
Reply to this email directly or view it on GitHub.
from zpanelx.
I agree that CNAME targets look better as lowercase... However, when reading RFC 4343, DNS Case Insensitivity Clarification, section 4, I see that 'case MUST be preserved on output and preserved when convenient on input.' -- does this mean that case should not be modified in general when applying to DNS?
https://www.ietf.org/rfc/rfc4343.txt
Is the keyword "when convenient" the reason to force CNAME in lowercase?
from zpanelx.
I agree with what you are saying, what I mean't was and am saying is that i'm saying that i'll add a conditional sting to lower for CNAME records only! TXT record values will therefore remain untouched (unformatted) thus will ensure that it abides to the RFC.
Sent from my iPhone
On 13 Mar 2014, at 23:36, Cody Cook [email protected] wrote:
I agree that CNAME targets look better as lowercase... However, when reading RFC 4343, DNS Case Insensitivity Clarification, section 4, I see that 'case MUST be preserved on output and preserved when convenience on input.' -- does this mean that case should not be modified in general when applying to DNS?
https://www.ietf.org/rfc/rfc4343.txt
—
Reply to this email directly or view it on GitHub.
from zpanelx.
I see. Thanks for the clarification. 👍
This will help me out tremendously as I have a lot of domains with TXT records. Thanks again.
from zpanelx.
This has now been fixed and latest version can be seen in this commit: 6e51c5e
from zpanelx.
Related Issues (20)
- Error in installing postfix. Not start postfix server HOT 7
- Zpanel on Ubuntu 14.04 already possible ? HOT 2
- Forum down? HOT 2
- named not receiving GUI updates for DNS
- modules.zpanelcp.com/repo is not working now?? HOT 6
- DNS .txt adding long txt records
- hotmail.com PHPMailer error HOT 1
- Import from other Control Panel systems HOT 1
- Ftp Auth - Invalid Password HOT 8
- Installation on Ubuntu is failed at mysql root password
- Freezes while installing zpanel HOT 1
- apache config reset HOT 1
- Zpanel account management HOT 1
- Security vulnerability reports HOT 1
- Postfix Database not correctly set up HOT 2
- Zpanel removed all mysql databases HOT 2
- Security: file inclusion issue HOT 3
- Zpanel on Ubuntu 16.04 possible ? HOT 1
- Where is ZPANEL? HOT 6
- ZPanel 10.1.1 allows XSS via the HTTP Host header to the etc/static/diskexceeded/index.php URI.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zpanelx.