Comments (3)
false
sounds reasonable, but yea, we should do what V8 does. If there isn't a test in test-api that we haven't brought over yet, then we should add one.
from v8monkey.
In fact, we should add tests for all of a Handle's methods that act on the handled pointer instead of the handle itself. I don't think that we can generalize that, short of creating a default item for empty Handles.
I'll check into what V8 does, though.
from v8monkey.
So maybe I should have just checked immediately: V8 asserts that the value isn't NULL
. I guess we should simply do the same and be done with it, then.
from v8monkey.
Related Issues (20)
- Implement RegExp HOT 2
- Fix test_api.cpp's test_ConversionException failures HOT 3
- Test failure in test_DefinePropertyOnAPIAccessor HOT 2
- Test failure in test_DefinePropertyOnDefineGetterSetter HOT 3
- Crash in test_IndexedInterceptorWithGetOwnPropertyDescriptor
- Fix test_api.cpp's test_CallbackFunctionName failures
- Object::GetConstructor is wrong (test_ObjectGetConstructorName) HOT 2
- FunctionTemplate related test failures HOT 1
- don't use vanilla new/delete
- Move FunctionTemplate::IsFunctionTemplate and ObjectTemplate::IsObjectTemplate to v8::internal HOT 2
- Fix test_api.cpp's test_DescriptorInheritance failures & crash
- Fix test_api.cpp's test_NamedPropertyHandlerGetter failures
- Fix test_api.cpp's test_FunctionTemplate failure HOT 1
- Test failure in test_PreInterceptorHolders
- Implement ObjectTemplate::MarkAsUndetectable
- test_StackTrace fails
- Fix TypedArray/ArrayBuffer post-merge
- Fix Script/ScriptData post-merge HOT 1
- Test IsFunction from test_value.cpp is invalid
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from v8monkey.