zpl_adt_node returned by zpl_json_parse() could have more useful parents

[rheatley-pervasid]

zpl_adt_node returned by zpl_json_parse() could have more useful parents

[zpl-zak]

Hi, thank you for the bug report. This issue is now resolved in version 18.1.3

[rheatley-pervasid]

@zpl-zak thank you for taking a look at the issue. I think sadly your change is not correct/safe.

When parsing the root (or any object) the node is initially created on the stack

zpl/code/source/parsers/json.c

Line 205 in d80f610

zpl_adt_node node = { 0 };

node is then passed into zpl__json_parse_value as a pointer to the stack variable so in later calls obj is still a pointer to the stack.
node isn't allocated from the allocator until the zpl_array_append call but all the child elements have the wrong parent at this point.
This is why I wrote the slightly obscure zpl_array_append_adt_node which retrospectively corrects the parent of all children.

I think my diagnosis is correct and it helps I seem to get incorrect results with your version (the parent nodes stop having names as they got zero-ed out by stack reuse)

[zpl-zak]

Thanks for the feedback; I'll be able to get back to it during the weekend. 👍🏻

[zpl-zak]

I had a look at it again, hopefully https://github.com/zpl-c/zpl/releases/tag/18.1.5 should resolve this issue now.