Giter Site home page Giter Site logo

Comments (9)

galexrt avatar galexrt commented on July 17, 2024

I'm working on a fix.

Could you tell me what changes you want to make to the Django config? Because then I could consider adding environment variables for the configuration of Django.

Thanks for the bug report!

from docker-zulip.

xeor avatar xeor commented on July 17, 2024

Thansk for the quick response! :)

I am using a proxy in front of this container that takes care of both https and some other things. So I had to change out the nginx config, killing https, and killing the redirect.

from docker-zulip.

galexrt avatar galexrt commented on July 17, 2024

@xeor I could add an environment Variable for disabling https and https redirect from the nginx in the container. So you don't need to modify the container files.
Would that be okay for you?

from docker-zulip.

xeor avatar xeor commented on July 17, 2024

That would be a very acceptable solution! I would imagine many people wanting to do this as well, so a generic fix would be good.

The post-setup.d issue would still be nice to have tho. Since it's undocumented, maybe you can write a little comment in the entrypoint script asking people to submit an issue, if their post-setup script fixes something that should be implemented as an environment-variable..

Thanks!

from docker-zulip.

galexrt avatar galexrt commented on July 17, 2024

I'm not removing the post-setup.d feature.
I just add an environment Variable like DISABLE_HTTPS, to disable nginx https and the https redirect.

from docker-zulip.

xeor avatar xeor commented on July 17, 2024

Cool.. But the post-setup.d feature is still broken, as it says that it's not able to find any files, if it finds files..

from docker-zulip.

galexrt avatar galexrt commented on July 17, 2024

As I already said, I'm going to fix the post-setup.d feature.
I can push the fix in about 30 minutes, after the image has been rebuilt, you can repull the image (docker pull quay.io/galexrt/zulip:latest).

from docker-zulip.

galexrt avatar galexrt commented on July 17, 2024

Can you try again with version v1.3.9-2 of the image?
In the v1.3.9-2 I fixed the post-setup.d script execution.

from docker-zulip.

galexrt avatar galexrt commented on July 17, 2024

The DISABLE_HTTPS env variable has been implemented in the dev-v1.3.10 branch.
Please don't use the dev-v1.3.10 image.
Closing as the feature has been implemented and we'll just have to wait until Zulip merges the official Dockerfile Pull request for this to work.

from docker-zulip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.