Comments (22)
Also figured out why IE is crashing but edge is not. In @zxing/library
you used Uint8ClampedArray.from
and Int32Array.from
functions and as developer I love the implementation, but those are not covered by default polyfills of angular, the correct polyfill is
import 'core-js/es6/typed';
which is solution for IE11, hope this will help in the future 🙂
from library.
Next monday we have a release scheduled, probably will be made on next sunday (20). I will do what I can to deploy this little guy working. ;)
from library.
Oh no! 😢
Let's give this dinossaur 🐱🐉 some attention.
from library.
As pointed by @andrevargas:
yarn build:before && tsc && tsc --target es2017 --outDir esm5 && webpack && webpack --env.prod
TS compiler is targeted to output ES6 files and is outpiting these in the ES5 folder. 🤦♂️
This is probably what's causing the issue zxing-js/ngx-scanner#93.
from library.
Hi guys I'm the author of zxing-js/ngx-scanner#93 Just FYI the build is not only thing that is crashing IE,I've build es5 correctly on my local and tested. I noticed few issues with using Array.from function which is crashing IE as well, after some modifications it worked but only on edge, for some reason IE kept loading script, not sure why. Also I failed on building the plugin under prod. I have deadline coming and I will be eternally in your debt if you can give me working release in upcoming few days 😏
from library.
@devgrigor did you checked your polyfills? IE is known by requiring them to work properly. Wating for this feedback.
from library.
@odahcam Yes. All polyfills are imported in polyfills.ts
from library.
Sh*t! I believe that as a first step we must publish the right EcmaScript files ASAP, then let's investigate the IE dinossaur. 🐱🐉
from library.
Build target fixed in 04fac3b. 🙂
from library.
Thanks @odahcam I noticed the correct files and I really don't wan't to be a need-picky a*$hole here, but ngx-scanner is still using version 0.3.2 and is always installing that instead of new one, even after
npm cache clean --force
from library.
So that's not a bug with the package itself?
Do you think we should add it to the docs as "How to support IE/Edge"?
from library.
No the bug is just missing special pollyfill and yes I believe mentioning that will help others.
Only thing that I'm waiting to close IE issue is the ngx-scanner
's new version with updated dependency of library
package
from library.
I believe that because of our dependency in ^0.3.2
, npm will just downloads the latest minor version, which is ^0.5.0
. A npm install
without package-lock is worth a try.
from library.
yep, which is done several times now. npm update
too. Same result
Just tried npm install @zxing/library@^0.3.2
on empty folder and still installed the 0.3.2
from library.
Oh, I can try to publish a dev version there so we can test it. Also, I would like to ask to keep this issue open until we add that note about IE in the wiki, thanks. 😄
from library.
ok. sure 🙂 Looking forward to it
from library.
@odahcam can you tell me when I can expect the dev version with new dependency ?
from library.
Sorry, something about this weekend. :/
You can also clone the ngx-scanner repo, ng serve
it and test the app on IE. 😉
from library.
I know it will work on IE, already tested 🙂 but I need it to work on server. Can I commit the change and make it dev release. If yes please let me know how exactly to do that
from library.
I will release v0.5.1 with this issue open, please test it to see if it works with the new version. Thx!
from library.
Closing as this seems to be resolved by polyfills presented in readme and build fixes.
from library.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from library.
Related Issues (20)
- Interleaved 2of5 Support HOT 2
- Failed to execute 'getImageData' on 'CanvasRenderingContext2D': The source width is 0. HOT 1
- Green screen when reading EAN code HOT 3
- multi-qr-code-reader support HOT 7
- Disabling Start/Stop character of CODABAR (DecodeHintType.RETURN_CODABAR_START_END) not working HOT 2
- UPC-E format always fails. HOT 1
- repeat decode report "Readers were able to detect the code" HOT 6
- Unable to scan the UPC-E HOT 4
- zxing-wasm: An alternative choice with active development for js users. HOT 1
- Can I generate code128 barcode image? HOT 1
- Support for ZXing.Net.Mobile in .NET 7 and above HOT 2
- Won't detect the barcode unless I position the barcode to the left side of the camera. HOT 2
- Not focussing correctly on iPhone 15 Pro HOT 1
- Scanning Qr Code from Image 2D does not work in Demo HOT 3
- Scanning Area (Crop) / Perfomance HOT 2
- Race condition when the reset function is being called shortly after calling decodeOnceFromVideoDevice() HOT 3
- QR CODE decodeFromImage err N HOT 1
- Error: [InvalidAccessError] Track has ended at applyConstraints ([native code]::)
- Unable to scan image with large black backgrounds HOT 1
- Add Support for willReadFrequently to Optimize Canvas Readback Performance HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from library.