Stackoverflow when using ReplaceChild

[enkelmedia]

Stackoverflow when using ReplaceChild

[JonathanMagnan]

Hello @enkelmedia ,

Thank you for the project. My developer will look at it.

Best Regards,

Jon

---

Sponsorship
Help us improve this library

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Dapper Plus

Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function

[JonathanMagnan]

Hello @enkelmedia ,

A custom exception pointing to this issue has been added in the v1.11.53

The issue was caused because the ChildNodes of a Child contained the same list of ChildNodes as his parent, which led to a stack overflow exception. See this part:

html-agility-pack/src/HtmlAgilityPack.Shared/HtmlNode.cs

Lines 1003 to 1016 in 7c35d8f

	public void SetChildNodesId(HtmlNode chilNode)
	{
	foreach (HtmlNode child in chilNode.ChildNodes)
	{
	_ownerdocument.SetIdForNode(child, child.GetId());
	if (child.ChildNodes == chilNode.ChildNodes)
	{
	throw new Exception("Oops! a scenario that will cause a Stack Overflow has been found. See the following issue for an example: https://github.com/zzzprojects/html-agility-pack/issues/513");
	}
	SetChildNodesId(child);
	}
	}

Another way to make it work is to clone the current node that you want to replace and use it:

if (tables != null && tables.Any())
{
	foreach (var table in tables)
	{
		var nestedTable = table.Clone();

		// Wrap the table in a div "table-wrapper" so that we can apply "mobile table"-css.
		var wrapperDivNode = HtmlNode.CreateNode("<div class=\"table-wrapper\"></div>");

		wrapperDivNode.ChildNodes.Add(nestedTable);

		table.ParentNode.ReplaceChild(wrapperDivNode, table);
	}
}

Let me know if everything is fine for you or there is something else related to this issue.

Best Regards,

Jon

---

Are you finding this library useful? If so, please consider supporting its continued development by becoming a sponsor.

Additionally, if you think your enterprise would benefit from this library, we encourage you to suggest they become a sponsor as well. Your support will help ensure this library remains alive and well-supported.