Take() and Skip() lose ElementType

[zzzprojects]

Take() and Skip() lose ElementType

[StefH]

I did create a unit-test which tests your scenario, but it seems to work fine.
Can you check the linked commit on this issue ?

[jotab123]

Your test works fine because you are getting the type from first element in the IQueryable results.

This test should fail:

        [Fact]
        public void SkipTestForEqualElementType()
        {
            // Arrange
            var testUsers = User.GenerateSampleModels(100).AsQueryable();

            // Act
            IQueryable results = testUsers.Where("Income > 10");
            var skipResult = results.Skip(1).Take(5);
            Assert.Equal(results.ElementType , skipResult.ElementType);
        }

[jotab123]

Checking another projects I found they are using IQueryable.Provider to create a query and seems to works fine. Maybe is a good aproach to solve this.

        public static IQueryable Take(this IQueryable source, int count)
        {
            if (source == null) throw new ArgumentNullException("source");
            return source.Provider.CreateQuery(
                Expression.Call(
                    typeof(Queryable), "Take",
                    new Type[] { source.ElementType },
                    source.Expression, Expression.Constant(count)));
        }

Class link: System.Linq.Dynamic

[StefH]

Thanks.

Issue is solved, new NuGet 1.0.6.0 is uploaded.

[jotab123]

Great! I was checking it and works fine.

It would be interesting that Take method could take 0 value also, an return the IQueryable instead of an error. In my case, I'm using a variable as take index and sometimes is 0, and It's valid. Actually I have to check if take = 0 and set it as 1.

Good job!

[StefH]

New version added to NuGet

[jotab123]

Works fine! thanks