0x80/firebase-tools-with-isolate

The Firebase CLI with isolate-package integrated to support monorepos

firebase-tools-with-isolate's Issues

Execute isolate before firebase file checks happen

When running npx firebase deploy using firebase-tools-with-isolate, firebase-tools will still perform some checks before calling isolate. That way, if the package is not built yet (first run, fresh project, ./isolate folder empty, etc) then firebase-tools will throw errors like this:

Error: Could not detect runtime for functions at C:\Users\frani\IdeaProjects\cdljovemaju\functions\isolate

or

Error: could not deploy functions because the "functions\isolate" directory was not found. Please create it or specify a different source directory in firebase.json

If we run npx isolate before deploying, or add isolate to the predeploy tasks, the files will be up to date and the deploy will succeed.

My suggestion is that isolate, from firebase-tools-with-isolate, should be called before the initial checks that firebase-tools performs.

Doesn't seem to work due to isolate being invoked from the workspace root

isolate is currently being invoked without any arguments:

firebase-tools-with-isolate/src/deploy/functions/prepareFunctionsUpload.ts

Line 152 in 952fd51

const isolateDir = await isolate();

And this causes it to run from the workspace root by default, and fail with:

i  functions: +++ Failed to isolate: Failed to find outDir in tsconfig. If you are executing isolate from the root of a monorepo you should specify the buildDirName in isolate.config.json.

You should pass it targetPackagePath based on the actual sourceDir in this case, no?

Support deploying 1st and 2nd gen functions together

When 1st and 2nd functions are deployed at the same time, the tools call prepare for upload twice, triggering the isolation process twice. This seems to lead to issues.

if (backend.someEndpoint(wantBackend, (e) => e.platform === "gcfv2")) {
      const packagedSource = await prepareFunctionsUpload(sourceDir, config);
      source.functionsSourceV2 = packagedSource?.pathToSource;
      source.functionsSourceV2Hash = packagedSource?.hash;
    }
    if (backend.someEndpoint(wantBackend, (e) => e.platform === "gcfv1")) {
      const packagedSource = await prepareFunctionsUpload(sourceDir, config, runtimeConfig);
      source.functionsSourceV1 = packagedSource?.pathToSource;
      source.functionsSourceV1Hash = packagedSource?.hash;
    }