0ximdigital/rxanimations

Repository for android animations Rx wrapper

rxanimations's Issues

can't import repo

I get this error:

NoSuchMethodError

java.lang.NoSuchMethodError: No virtual method lambda$call$1(Lrx/CompletableSubscriber;Landroid/support/v4/view/ViewPropertyAnimatorCompat;)V in class Loxim/digital/rxanim/AnimateOnSubscribe; or its super classes (declaration of 'oxim.digital.rxanim.AnimateOnSubscribe' appears in /data/app/package-app-2/split_lib_dependencies_apk.apk) at oxim.digital.rxanim.AnimateOnSubscribe$$Lambda$2.run(Unknown Source) at android.view.ViewPropertyAnimator$AnimatorEventListener.onAnimationEnd(ViewPropertyAnimator.java:1121) at android.animation.ValueAnimator.endAnimation(ValueAnimator.java:1171) at android.animation.ValueAnimator$AnimationHandler.doAnimationFrame(ValueAnimator.java:722) at android.animation.ValueAnimator$AnimationHandler.run(ValueAnimator.java:738) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:767) at android.view.Choreographer.doCallbacks(Choreographer.java:580) at android.view.Choreographer.doFrame(Choreographer.java:549) at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:753) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:135) at android.app.ActivityThread.main(ActivityThread.java:5343) at java.lang.reflect.Method.invoke(Native Method) at java.lang.reflect.Method.invoke(Method.java:372) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:905) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:700)

Concat fade in and fade out

Solved:
RxAnimations.fadeIn(image1, 2000).andThen(RxAnimations.fadeOut(image1, 700)).repeat().subscribe();

Rewrite code to RxJava 2.0

Hi, have you wonder about rewriting Your animations to RxJava 2.0?

RxValueAnimator support for RxJava 1.2+

Recently, RxJava 1.2.0 has been released and they've made some backward-incompatible changes related to Completables, specifically:

• CompletableSubscriber -> rx.CompletableSubscriber
• CompletableOnSubscribe -> rx.Completable.OnSubscribe

After upgrading to it, I'm getting the following gradle build issues on :

RxValueAnimator.from(myValueAnimator, animator ->{
              ...
 });

Error:(347, 24) error: cannot access CompletableOnSubscribe class file for rx.Completable$CompletableOnSubscribe not found

Manifest contains unhelpful items

I just tried to add RxAnimations 0.9.0 to my project, and I immediately started getting build errors.

Error:
	Attribute application@supportsRtl value=(false) from AndroidManifest.xml:22:9-36
	is also present at [oxim.digital:rxanim:0.9.0] AndroidManifest.xml:14:9-35 value=(true).
	Suggestion: add 'tools:replace="android:supportsRtl"' to <application> element at AndroidManifest.xml:19:5-96:19 to override.

This is because the library's AndroidManifest.xml includes values for allowBackup and supportsRtl which don't belong in a library project.

android:allowBackup="true"
android:label="@string/app_name"
android:supportsRtl="true"

RxAnimationBuilder addPre/PostTransform actions

It would be great if we can add preTransform and postTransform actions to the RxAnimationBuilder, which is called before/after the main animations. Something like this:

public RxAnimationBuilder addPreTransformAction( Action1<ViewPropertyAnimatorCompat>... actions) {
        Observable.from(actions)
              .subscribe(action -> this.preTransformActions.add(action));
        return this;
}