0xproject / 0x-launch-kit-frontend Goto Github PK
View Code? Open in Web Editor NEWLicense: Apache License 2.0
License: Apache License 2.0
On the orderbook, the trade size amount shows only two decimals, the rest are zero paddings, even when the real value is not that, for example:
size value: 5.015, UI displays: 5.010
Let's start with testing manually launch-kit frontend using an existing already-deployed launch-kit backend.
As a logged in user, I should be place a market order (buy/sell).
Check the comments around: #55 (comment)
Project setup and initial configuration.
When the user go to metamask and change the current account or the current network, the UI should be re-rendered based on that information
When the user clicks on the ETH / wETH box, a similarly styled input should be shown.
Right now, we only have the address of the 0x token.
Update accordingly the following file...
https://github.com/0xProject/0x-launch-kit-frontend/blob/buy-sell-market/src/common/tokens_meta_data.ts
... So the preview in Netlify + Kovan is nicer.
Children of #61
Check #58 comments/updates.
The "Filled" tab of the Orders component shouldn't show the cancel button for those orders.
Depends on #58
The USD price of ETH should be saved in the store and updated regularly. Components that use it should just get it from the store.
This means that this value will be nullable, since there's a time window —between the start of the app and the moment the price is obtained— in which the price is unknown. Also, the API could be down. So any component that depends on this should handle the case in which the value is not known.
Originally posted by @Agupane in https://github.com/_render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDc1OTc2Ng==/comments/review_comment
The total size for a price in the order book should not take into account the filled values.
For example, an order of size 100 with 30 filled, should add 70 to the total size for its price.
The same probably applies too to the "My size" column.
Display current user Orders:
In the deployed app (https://0x-launch-kit-frontend.netlify.com/) go to "My Wallet" and refresh. A "Not found" message shows up.
It seems like this can be the fix: https://www.slightedgecoder.com/2018/12/18/page-not-found-on-netlify-with-react-router/
Implement main layout, including navbar.
As a logged in user, I'd like to be notified every time an order but/sell order is executed/updated.
Update: This version covers only those events that occur while user is 'online'. #106 deals with 'offline' events.
Tests are taking ~30 seconds to start (at least on my not-that-fast laptop). Maybe there's something that can be done to speed them up? At the very least, compilation should be incremental when using jest in watch mode.
As a user, I'd like to see prices, sizes, statuses updated in realtime, so I don't have to manually refresh the page.
This first iteration of this feature aims to implement this real time updates via polling.
Open for discussion
As a user, in my account page, add token icons next to each token name.
Grab icons from: https://github.com/MetaMask/eth-contract-metadata
As a user, I should be able to switch the selected token. The corresponding dropdown in the main top-toolbar should list all the available tokens as listed in "My Wallet".
The tokens' information to be displayed covers basic data:
Also, this should update the corresponding symbol on the buy/sell forms accordingly.
NOTE, this issue does not cover:
Check if is necesary to use polling in order to receive the user account changed / networks events on wallets like nifty wallet. The current implementation uses events and it's supported on metamask but not tested on nitfy wallet.
Based on the comment: #84 (comment)
Add base modal to implement user interaction flows (e.g: "Create order with no WETH and no unlocked ZRX", "Create order with no ZRX", etc).
Assume the first flow is going to be simple: "Sign Order + submit to the relayer backend" (assume WETH and ZRX are unlocked + enough balance).
Use the maker and taker fees along with the order price to compute the total fee in ETH.
After this is done, we should add some mechanism for obtaining the price of ETH in USD.
As a logged in user, I should be place a limit order (buy/sell).
Right now tokens can only be unlocked. The user should be able to lock them back.
Children of #61
As a logged in user, I should be able to cancel an order of mine.
We are using a type="number"
input, which can cause precision errors. Let's change it for a BigNumberInput
. Also, if there are places where the price is represented as a number, they should be changed to BigNumber
.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.