100xdevs-hkirat/week-2-assignments

FullStack Development Course Assignments

Each assignment has its respective instructions for the setup, running, testing and submitting it.

• If you have any query then ping us on the Discord server.

week-2-assignments's Issues

Test cases of the authentication.js aren't aligned with the description of the assignment

1. The description of all the routes has id field as well, which is generated every time a new user is created and is unique to each user. But the test cases has no mention of the id field.

2. The expected response of /login route says

Response: 200 OK with an authentication token in JSON format if successful, or 401 Unauthorized if the credentials are invalid."

But, the tests are not checking if auth code is being returned as response or not.

I would suggest, the tests to be revisited once.

Assigning value to constant variable

In the delete route of todoServer.solution.file.js(in 02-nodejs/solutions), Value is assigned to constant variable causing an error

Route not found to be mentioned in fileServer.js

Need to mention this line
"- For any other route not defined in the server return 404.Should return Route not found as text if route is not found."

instead of "- For any other route not defined in the server return 404."

It fails during test case otherwise.

use email instead of username

mistake in solution of authenticationServer.js file

task 03 in which we are making usersToReturn array in order to return it as a response instead of returning it in solution it is returning the whole users array itself.
why filter the users array then if at the end it is returning users.
link

Tests are not running when npm run <testname> is put

I have a solution for this and will be making a pull request to solve. Hey @hkirat if you find this issue please
kindly check and merge the pull request or make the changes yourself.

Change of URL route of file to files in fileServer.test.js

In the line 53 of fileServer.txt.js

describe('GET /file/:filename', () => { should be describe('GET /files/:filename', () => {

'file' should be 'files' because we are provided the files directory and above this code in line 20 we are using 'files' for routing

"500 Status code to be returned in case of error GET /files" not mentioned explicitly in problem statement

In Response of GET /files we can mention explicitly that 500 status code to be returned in case of error reading directory