18f/forecast

A contracting opportunities forecasting tool (beta)

forecast's Issues

Enforce dollars for the Price Min and Price Max fields

Visual Bug: some admin icons misaligned

See trello: https://trello.com/c/d347tzV8/117-visual-bug-some-icons-misaligned-on-admin

Make all field required

Make main page pagination more user-friendly

This includes several sub-issues:

• Clicking the ... should should show additional pages in that direction
• The current page should be highlighted in the list
• The URL should include a query for the page

Notification that this site is in beta

As a visitor to this US government website, I want to know whether this site is a work in progress.

This site should contain the marker 'beta' somewhere at the top of the page.

Enforce correct fiscal year and quarter

Add this (additional) agency data into the data set.

Client is very interested in showing GSA and Dept of Education and Dept of State data. Please load this data so that it is sortable during the next demo of the MVP.

DepEducation-OpenOpportunities-Forcecast.xlsx
DeptState-FY15-Opportunities-235609.xlsx

Determine how to handle opportunities in multiple states

A number of opportunities use multiple states (e.g. "ME, VT, NY") or have non-state entries such as "NATIONWIDE", "VARIOUS LOCATIONS", or "KOREA". As a result, the two-character limit imposed by localflavor to create the model field for states doesn't work for the data that we have.

Do we want to make sure that the performance place is one state, or do we want to open that field up to align with the previous data?

Drawing a top-level diagram of the system architecture

See https://pages.18f.gov/before-you-ship/ato/.

508 Issues from pa11y-rails

Results can be recreated using HTML_CodeSniffer

Results for https://forecast-staging.18f.gov

• Error Form does not contain a submit button (input type="submit", input type="image", or button type="submit").
  • WCAG2AA.Principle3.Guideline3_2.3_2_2.H32.2
  • #results > form
  • `
    ...`
• Error This button element does not have a name available to an accessibility API. Valid names are: title attribute, element content.
  • WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.Button.Name
  • #results > div > drawer > button
  • <button class="fa fa-close" data-drawer-toggle="close" tabindex="-1"></button>
• Error Anchor element found with a valid href attribute, but no link content has been supplied.
  • WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.A.NoContent
  • html > body > footer > div > div > div:nth-child(2) > div > a:nth-child(1)
  • <a href="#"> <span class="fa-...</a>
• Error Anchor element found with a valid href attribute, but no link content has been supplied.
  • WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.A.NoContent
  • html > body > footer > div > div > div:nth-child(2) > div > a:nth-child(2)
  • <a href="https://twitter.com/GSAOSBU"> <span class="fa-...</a>
• Error Anchor element found with a valid href attribute, but no link content has been supplied.
  • WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.A.NoContent
  • html > body > footer > div > div > div:nth-child(2) > div > a:nth-child(3)
  • <a href="https://www.youtube.com/playlist?list=PLvdwyPgXnxxVYR0faPu0NJ-dIXUqIVsUW"> <span class="fa-...</a>
• Error Anchor element found with a valid href attribute, but no link content has been supplied.
  • WCAG2AA.Principle4.Guideline4_1.4_1_2.H91.A.NoContent
  • html > body > footer > div > div > div:nth-child(2) > div > a:nth-child(4)
  • <a href="#"> <span class="fa-...</a>
• Error Duplicate id attribute value "opportunity-row" found on the web page.
  • WCAG2AA.Principle4.Guideline4_1.4_1_1.F77
  • #opportunity-row
  • `
  • CFO-Chie...
  `
• Error The html element should have a lang or xml:lang attribute which describes the language of the document.
  • WCAG2AA.Principle3.Guideline3_1.3_1_1.H57.2
  • html
  • ` <title> OSBU Forec...`
• Error Form does not contain a submit button (input type="submit", input type="image", or button type="submit").
  • WCAG2AA.Principle3.Guideline3_2.3_2_2.H32.2
  • #agency
  • `

Viz bug – Place of Performance template

The place of performance field has an extra space and comma if only the State is available:

There are likely other templating issues that I didn't run across, so a more thorough logic should probably be added to the part of the opportunities main view

Determine how to handle errors in uploaded CSVs

Currently, the system allows an admin to upload a CSV of opportunities into the database. Some (most) of those CSVs will have rows with unexpected values, and we should figure out what we want to happen. Since this is so common, I think it's not the best idea to have the upload fail. Here are two alternatives:

• Allow the upload to succeed and insert defaults ("None", in many cases) for bad values.
• Upload only the rows with expected values and output a CSV of all the rows with bad values in case the user wants to correct issues.

These could both be implemented, with one being the default and the other being optional.

As an admin, I need the 18F and DAP Google Analytics codes to track visitors.

XPOST from 18F/osbu-forecast#6

Updating relevant documentation, primarily the README

See https://pages.18f.gov/before-you-ship/ato/.

Implement caching

The DB call for the main page slows down the loading time for the page, so it would be good to have some sort of caching to speed things up.

Some documentation for how to do this is here: https://docs.djangoproject.com/en/1.8/topics/cache/

Implementing the security controls

See https://pages.18f.gov/before-you-ship/ato/.

Add swagger documentation

https://github.com/marcgibbons/django-rest-swagger

Upload other agencies' data

As a small business user, I would want to see many agencies' data in one site. Please upload forecast data from more federal agencies into this platform.

Resolving any visible security issues

See https://pages.18f.gov/before-you-ship/ato/.

Switch DB from sqlite3

This is important for persistence in production. Switching to PostgreSQL is a reasonable choice.

Auto scrollTop on next page

When clicking through to another page, users should see the new page, scrolled to the top.

Selecting the security controls

See https://pages.18f.gov/before-you-ship/ato/.

Page is confusing mid-load on slower connections (until pagination loads)

No idea where the repo for this is, but I noticed while loading the site on a slow connection that it loads all of the content of all of the opportunities and only puts in the pagination later (so the slow loading process leave a giant page with infinite scroll). Apologies if y'all already saw that!

UX/UI - Wireframes

All wireframe are here https://invis.io/KD530ALCM
Please build out for the completion of the Alpha stage of this project.

Create /developer page

Create a simple page at https://gsaforecast.18f.gov/developer (and have https://gsaforecast.18f.gov/developers redirect to it). On this page, a good MVP would be just 2-3 simple sentences about what is available via the API, a link to the endpoint, and any other API documentation that you have.

Add tests

Incorrect margin-right on main section

I noticed that when I first load the page, <section class="usa-width-three-fourths"> still has its margin-right value set, which causes it to fall below the filters, rather than next to it. Eventually, once the page is loaded, the correct :last-child { margin-right: 0 } property gets set. I can't tell why it's doing this, but wanted to log.

What should the search bar include?

As discussed in #45.

Enforce NAICS code as 5-digits

Conducting a preliminary code review

See https://pages.18f.gov/before-you-ship/ato/.