1forge/python-forex-quotes

Library to fetch and parse realtime Forex quotes and convert currencies

python-forex-quotes's Issues

Python3 changes

import urllib.request, json


class ForexDataClient:
    def __init__(self, api_key):
        self.api_key = api_key
        self.base_uri = 'http://forex.1forge.com/1.0.2/'

    def fetch(self, uri):
        response = urllib.request.urlopen(self.base_uri + uri + '&api_key=' + self.api_key)
        return json.load(response)

    def quota(self):
        return self.fetch('quota?cache=false')

    def getSymbols(self):
        return self.fetch('symbols?cache=false')

    def getQuotes(self, pairs):
        return self.fetch('quotes?pairs=' + ','.join(pairs))

    def marketIsOpen(self):
        data = self.fetch('market_status?cache=false')
        try:
            return data['market_is_open']
        except:
            print(data)

    def convert(self, currency_from, currency_to, quantity):
        return self.fetch('convert?from=' + currency_from + '&to=' + currency_to + '&quantity=' + str(quantity))

print data to print(data) and then urllib to urllib.request and this is working for me with python3 if anyone is so inclined

Is 1Forge data only for European companies?

I don't see the symbol for AAPL for example. Could you please confirm?

Thank you,
-Júlio

urllib module

Source code present only in tar.gz

I noticed that the files python_forex_quotes/ForexDataClient.py and python_forex_quotes/__init__.py are only present in dist/python_forex_quotes-1.0.tar.gz. Is it possible for you to make all the source code files available so that one need not download and extract them? Thank you.

urlopen timeout

Please make changes, sometimes freezes.

def __init__(self, api_key, timeout = 10):
        ...
        self.timeout = timeout

def fetch(self, uri):
        response = urlopen(self.base_uri + uri + '&api_key=' + self.api_key, timeout = self.timeout)
        ...