Comments (6)
@ssalonen thanks for the analysis.
I would suggest the fix number 2, and increasing to 816 for ESP32, the other boards with lower ram will not be impacted as they have a separate definition for JSON_MSG_BUFFER
.
Also Arduino boards support will be removed soon.
from openmqttgateway.
@1technophile I can happily provide a fix for this one, but let me know if there's something else to try out that would cause a crash
from openmqttgateway.
I also note here that ruuvi is having longest properties (json props json string), at 513 bytes. Second largest is 409 bytes (device index 34, thermobeacon). Of course the StaticJsonDocument needs some more for the overhead
This gives a good indication that there are no other tricky devices
from openmqttgateway.
I will file a PR bit later.
Will also include error handling
from openmqttgateway.
The regression might have happened in recent PR where props have become larger, eg
theengs/decoder#359
Or
theengs/decoder#452
from openmqttgateway.
See PR #1906 for the fix.
I also propose we log any deserialization errors, see #1907 (the rest of the function body still would get executed). In #1907 I did not tweak the implementation any further to avoid access invalid pointers (like what happened here) - I would expect a crash with ESP8266.
from openmqttgateway.
Related Issues (20)
- SwitchBot Outdoor does only extract values in rare cases HOT 32
- TTGO Lora 1.7.0 issue respect 1.6.1 HOT 28
- Version 1.7 Lacrosse-TX141W not reporting temperature and humidity anymore. HOT 12
- Stable OMG/BLE operation with 1.7.0! HOT 1
- Full reset doesn't work, if there is no config.json HOT 2
- WebUI is missing quotes on placeholder attributes HOT 1
- Add support for Lilygo T3-S3 HOT 2
- Enable additional OOK RF decoders HOT 1
- RTL-433 Missed transmissions HOT 8
- Inaccurate Readings and Sporadic Data Retrieval from LaCrosse Sensors using OpenMqtt with ESP32 and CC1101 HOT 2
- Exception when trying to enable external decoder HOT 15
- Invalid JSON in Home-Assistant config topic HOT 1
- Add configuring IP adress to 1.8.0 ? HOT 4
- GL-S10 (IP101 Ethernet) does not connect
- Pilight rawEnabled fails
- Pin correspondance atk-lora-01 HOT 8
- Wrong state topic (stat_t) in homeassistant config payload for TPMS-Jansite-Solar HOT 2
- Which DIY card do you recommend ? HOT 5
- ESP32 + SX12xx or "ttgo-lora-v1" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openmqttgateway.