Giter Site home page Giter Site logo

Comments (4)

gowthamrm avatar gowthamrm commented on August 15, 2024

@rondale-sc The regex used to match and replace the css files does not work well with the fingerprinted assets. Have fixed the same in this PR. Please do have a look.

from ember-inline-css.

sohara avatar sohara commented on August 15, 2024

In our app we are excluding the css assets to be in-lined from fingerprinting, as described here: https://ember-cli.com/asset-compilation#fingerprinting-and-cdn-urls

I wonder if this would solve the issue and obviate the PR? Either way, might be good to mention it in the readme?

from ember-inline-css.

rondale-sc avatar rondale-sc commented on August 15, 2024

@gowthamrm Sorry, musta missed this. I can tell you that I have this code such as it is in place on a few production sites. If I get free I'm going to try to boot your repro.

from ember-inline-css.

steveszc avatar steveszc commented on August 15, 2024

Can confirm @sohara's suggestion that excluding the inlined css file from fingerprinting is a work around for this issue.

from ember-inline-css.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.