201-created/ember-inline-css

An Ember/Glimmer addon for inlining app CSS

ember-inline-css's Issues

Not working in the Ember's Production Environment

CSS inlining is not working with the ember production build, it is working fine with the development build though.

Reproduction:
Tried ember-inline-css addon in this ember addon repo (ember-scroll-preview). CSS got inlined properly in the development, but failed with the production environment (ember build --environment=production).

Addon not working in my app

Hi,

I installed this addon but immediately ran into the following issue

The Broccoli Plugin: [BroccoliMergeTrees] failed with:
Error: ENOENT: no such file or directory, open '/Users/ian/workspace/5b/b5b/tmp/cssreader-
input_base_path-zrx82clx.tmp/assets/undefined�

Is there any configuration that I need to do?

Inline based on size

Change the inlining logic to be based on file size. For example if a CSS file is 100K, it should not be inlined. If it is 4K, it should be. I suggest 40K as a reasonable cutoff.

This should also be configurable.

Dealing with embedded SVGs with style tags

This module will completely break rendering of an ember app if the app has styles which have embedded SVGs which themselves contain <style> tags. Maybe those things need to be escaped? Detected somehow and generate a helpful error? This was quite difficult to track down.

Setup CI

Add travis or some alternative CI to this project.

Improve the README

It would be useful to have more information on the README describing how to use this adodn.