audit trigger: problem with schema

[2ndquadrant]

audit trigger: problem with schema

[ringerc]

No time at the moment, but you shouldn't have any issues modifying the trigger to take regclass instead of text arguments for table names, then injection issues go away entirely and you don't need quote_ident.

[3nids]

Hi,
Thanks a lot for your reply.
target_table is already received as a regclass.
I don't get why there's quote_ident(target_table::text) written, target_table should be enough right?

[ringerc]

On 05/07/2013 08:28 PM, Denis Rouzaud wrote:

Hi,
Thanks a lot for your reply.
target_table is already received as a regclass.
I don't get why there's quote_ident(target_table::text) written, target_table should be enough right?

If it's already regclass then yes, that's just a stupid mistake on my part.

Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

[3nids]

I just pull a request if it's ok for you!
Thanks a lot for you work!

[ringerc]

Took a look, understood the issue, merged @3nids's pull (thanks!) and closed.