Comments (5)
I tend to agree. I won't have time to fix it up in the next few days, but if you're happy to send a pull request I can merge it.
from audit-trigger.
You're Craig Ringer in SO aren't you? :)
I've made the request. Took me a while to figure out how. I just removed the not null
in the fork, but in my local use, I actually made every column nullable (just to be sure this doesn't happen again - I don't want the main application to fail) and there's no value check in action
column.
In any case, what is TG_ARGV[0]
Is the if
check for avoiding the insert of current query for row triggers (only inserted for statement triggers)?
from audit-trigger.
On 01/27/2014 06:25 PM, ADTC wrote:
You're Craig Ringer in SO aren't you? |:)|
I've made the request. Took me a while to figure out how. I just removed
the |not null| in the fork, but in my local use, I actually made every
column nullable (just to be sure this doesn't happen again - I don't
want the main application to fail).
If there's any circumstance where a table trigger can fire with no
relation oid, tble name, or schema name set, then there's something
really, really weird going on.
In any case, what is |TG_ARGV[0]| Is the |if| check for avoiding the
insert of current query for row triggers (only inserted for statement
triggers)?
I don't understand that paragraph.
TG_ARGV[0] ie the first argument in the trigger argument array. (It's
zero-indexed, unlike most arrays in PostgreSQL). That argument is a
boolean, defaulting to 't', controlling whether this trigger invocation
should log the query text.
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
from audit-trigger.
Apologies, I missed a question mark in that paragraph (eats, shoots and leaves!)... I meant to ask: What is TG_ARGV[0]? (first question) followed by: Is the if check for avoiding insert of current_query [...] ? (second question)
You have answered the questions adequately, except what determines whether the query text is logged or not? (that is, what sets the value of TG_ARGV[0]?)
Anyway I should probably look through the code to get the answer. I'll close this issue as it's not important to have the answer. :)
from audit-trigger.
On 01/28/2014 03:51 PM, ADTC wrote:
Apologies, I missed a question mark in that paragraph /(eats, shoots and
leaves!)/... I meant to ask: What is TG_ARGV[0]? (first question)
followed by: Is the /if/ check for avoiding insert of current_query
[...] ? (second question)You have answered the questions adequately, except what determines
whether the query text is logged or not? (that is, what sets the value
of TG_ARGV[0]?)Anyway I should probably look through the code to get the answer. I'll
close this issue as it's not important. |:)|
TG_ARGV[0] is set by the first argument you pass at CREATE TRIGGER
time.
https://github.com/2ndQuadrant/audit-trigger/blob/master/audit.sql#L153
which is passed as:
https://github.com/2ndQuadrant/audit-trigger/blob/master/audit.sql#L181
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
from audit-trigger.
Related Issues (20)
- audit_table(regclass) function chokes in v9.2 after running audit.sql to set up HOT 6
- save primary key in a column HOT 6
- How do I use to audit tables in different schemas ? HOT 5
- Adding trigger to user table HOT 1
- Function error when inserting new row. HOT 1
- Query to display the data
- The logged_actions table is not updating HOT 2
- Audit failing with ERROR out of memory HOT 2
- Cannot add tables with CamelCase HOT 2
- auditing changes to tables with hstore columns is not working HOT 1
- storing TG_RELID (oid) is not "portable" across backup/restore HOT 1
- How to store UserName who is Updating the value of a table For Update Trigger?
- Enhancement: View displaying list of tables/schemas for which auditing is enabled HOT 1
- Convert to extension
- Statement only trigger not consistent with ORMs HOT 1
- Is it possible to log variables used in "where" clause? HOT 2
- Recommended security configuration question
- Why do comments say the transaction id "May wrap, but unique paired with action_tstamp_tx" HOT 3
- make CREATE INDEX idempotent
- Normalize client query-level columns to avoid redundancy HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from audit-trigger.