Comments (4)
I suggest to change once in one place of the code all the width values ββin the object with the data received from the streetmix API. So as not to convert to meters everywhere where necessary. @kfarr what do you think about this?
Because, the processSegments function in aframe-streetmix-parser recieve only part of recieved JSON with segments data. But the schemaVersion
, as well as units
, are at a higher level in recieved JSON.
That is, there will be no need to change the structure of existing code. And remove the conversion of feet to meters everywhere. And moving it to the moment the JSON response is received from the API in streetmix-loader
component
from 3dstreet.
More notes and sample API responses for new metric responses:
PR #486. Tested with all cases from here streetmix/streetmix#2900
from 3dstreet.
I'll change tests also
from 3dstreet.
Just sharing notes testing with a streetmix staging server providing metric responses
Testing technique, load the 3dstreet app and type the following in console:
newEl = document.createElement('a-entity')
newEl.setAttribute('streetmix-loader', 'streetmixAPIURL: https://streetmix-staging.herokuapp.com/api/v1/streets?namespacedId=295')
parentEl = document.querySelector('#street-container')
parentEl.appendChild(newEl)
Behavior on 3dstreet.app (production) using OLD parser, parsing the NEW streetmix metric API response. This is using old parser that does not support metric, therefore we expect this to look incorrect, and it does!
Behavior on github.3dstreet.org with NEW streetmix metric API response which supports the new metric api is correct:
Behavior on github.3dstreet.org with OLD streetmix imperial API response:
Therefore both imperial and metric responses work as expected on the new release. I think we're good!
from 3dstreet.
Related Issues (20)
- map diagram for forms (idea for later)
- remove rigging from vehicles HOT 1
- docs for passing data to 3DStreet via hash
- svg extrude bevel uses bevelColor instead of color when bevelEnabled is false HOT 2
- when releasing mouse button (click up) while using transform controls on a currently selected entity, do not select another item
- ability to choose new stencil mixins
- ability to change street component parameters without scene reloading HOT 1
- bring 3dstreet editor into core HOT 1
- create `street-geo` wrapper component HOT 1
- Backport some changes from aframe-inspector HOT 3
- fix outstanding things after combining repos HOT 1
- add karma for automated launching of browser test
- implement `street-geo` component in Editor HOT 10
- fix linting errors HOT 8
- save / load - architecture and migration plan
- Firebase error when changing scene title HOT 1
- Create street-stencil component
- The saved JSON scene is not loading correctly HOT 2
- as a local developer I want to run 3dstreet using dev credentials
- as a new developer to 3DStreet I need instructions on how to setup a dev (local or remote)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 3dstreet.