3x3y3z3t/atmohydropower

The script part for SE mod "Atmo Thrusters with Hydrogen (Standalone)"

atmohydropower's Issues

Crashes when pasting grid onto powered grid

Description

Crashes when pasting grid with Atmo Hydro Thruster onto powered grid.

Expected behavior

To Reproduce

Steps to reproduce the behavior (not always reproducible):

1. Create a grid with thruster.
2. Copy and Paste that grid onto an existing powered grid.
3. Game crash.

Additional context

SE Log:

2022-08-09 04:17:59.134 - Thread:   1 ->  Exception occurred: System.NullReferenceException: Object reference not set to an instance of an object.
   at AtmoHydroPower.AtmoHydroPower_GameLogic.UpdateOnceBeforeFrame()
   at VRage.Game.Components.MyGameLogicComponent.VRage.Game.Entity.EntityComponents.Interfaces.IMyGameLogicComponent.UpdateOnceBeforeFrame(Boolean entityUpdate)
   at VRage.Game.Entity.MyGameLogic.UpdateOnceBeforeFrame()
   at VRage.Game.Entity.MyGameLogic.UpdateBeforeSimulation()
   at Sandbox.Game.World.MySector.UpdateBeforeSimulation()
   at Sandbox.Game.World.MySession.UpdateComponents()
   at Sandbox.Game.World.MySession.Update(MyTimeSpan updateTime)
   at Sandbox.MySandboxGame.Update()
   at Sandbox.Engine.Platform.Game.UpdateInternal()
   at Sandbox.Engine.Platform.Game.RunSingleFrame()
   at Sandbox.Engine.Platform.FixedLoop.<>c__DisplayClass11_0.<Run>b__0()
   at Sandbox.Engine.Platform.GenericLoop.Run(VoidAction tickCallback)
   at Sandbox.Engine.Platform.Game.RunLoop()
   at Sandbox.MySandboxGame.Run(Boolean customRenderLoop, Action disposeSplashScreen)
   at SpaceEngineers.MyProgram.Main(String[] args)

Thruster block spins up from cold normally even when power is briefly supplied

Description

Thruster block only start up from cold when both electrical power and hydrogen gas is supplied. Both are required constantly for the spinning up duration of 1s.
However, currently thruster still start up fully even when electrical power is briefly supplied.

Expected behavior

Thruster should stop the spin up sequence right after electrical power is cut of, because its internal generator is not up and running yet.

To Reproduce

Steps to reproduce the behavior:

1. Create a grid with hydrogen-supplied thruster and a battery.
2. Turn off the battery and make sure thruster is completely stopped (wait more than 5s).
3. Turn on the battery and turn if off immidiately (double click on Enable button in terminal).
4. See the thruster turns on normally. It should turns on briefly, then turns off.