5afe/bivrost-kotlin

🔥 🌈 Bridge between Solidity Contracts and Kotlin

bivrost-kotlin's Issues

Convert to gradle plugin

We should be able to apply the abi as a gradle plugin to any project

Decoding data should return the Solidity type (wrapper)

Each solidity type should also have a way to access the raw/native value (Java/Kotlin type)

Add badges to readme

add encodePacked

@rmeissner commented on Mon Dec 09 2019

It should be possible to use encodePacked with Types

`Unresolved reference: intValueExact` on v0.7.0 on Android

Expected behavior

Code generated by bivrost-kotlin should also compile on Android

Actual behavior

I'm getting Unresolved reference: intValueExact compilation error for code generated based on a particular contract.
The generated code seems to be using the new stuff about encoding dynamic types.

Steps to reproduce the behavior

I created an example project that is seeing this behavior.
It's a basic Android app project that uses bivrost to generate code from an ABI also in the repo:
https://github.com/mirceanis/bivrost-kotlin-eval

It seems there's no intValueExact method on the BigInteger class on Android.

Add abi project to travis

• We want tests to be run automatically for each commit
• We want to deploy releases to GitHub when we create an tag

Update package for generated ABI sources

Add missing test scenarios

• Test method id generation when we have alias types in the method signature

Code gen fails with `Required value contractName missing at $` in v0.6.2

Expected behavior

Generating code for a contract compiled with a recent version of truffle should work.

Actual behavior

in v0.6.2, code generation fails with:
Required value contractName missing at $

Looks like abi generated by truffle is adding a field called "contractName" and the parser expects to see "contract_name".
The workaround is to manually change the field name in the abi json.
There is a feature/update_json branch that seems to fix this, and is already in master.

Is it possible to have a 0.7.x release with recent fixes including this?

Generate equals() and hashCode() for Bytes and BytesN

Expected behavior

Comparing different Bytes and BytesN based on their values, not reference. Right now we need to access their contents for comparison.

Actual behavior

Comparing these classes will compare the references which is not really useful for most use cases. We should implement the equals() and hashCode() methods in order to easily compare their values.

Use internalType for tuple names

Migrate to GitHub actions

Currently the build process relies on Travis. As Gnosis has moved to GitHub action this project should also be migrated.

Notes:

• Remove GITHUB_API_KEY usage as it will be deleted beginning of July
• Same has to be done for Svalinn: 5afe/svalinn-kotlin#52

Tests should check if the generated classes are present

Optimize network calls

Combine multiple rpc calls:

[{
"method": "eth_estimateGas",
"params": ["0xa5056c8efadb5d6a1a6eb0176615692b6e648313"],
"jsonrpc":"2.0",
"id": 42
},{
"method": "eth_gasPrice",
"params": [],
"jsonrpc":"2.0",
"id": 45
},{
"method": "eth_getTransactionCount",
"params": [
"0xa5056c8efadb5d6a1a6eb0176615692b6e648313",
"latest"
],
"jsonrpc": "3.0",
"id": "dkhfgs"
}]

Replace deprecated variante methods

variantOutput.getProcessResources() has been deprecated and should be replaced with variantOutput.getProcessResourcesProvider().

Warnings show pm.gnosis.plugin.BivrostPlugin$configureCodeGeneration$1.execute(BivrostPlugin.kt:13) as the location of the call

-> https://github.com/gnosis/bivrost-kotlin/blob/master/bivrost-gradle-plugin/src/main/kotlin/pm/gnosis/plugin/BivrostPlugin.kt#L49

Generate decoders for function definitions

Add alias for byte (same as bytes1)

Complete community checklist on github

https://github.com/gnosis/bivrost-kotlin/community

Add string encoding/decoding

Add tuples support

Fix encoding for fixed length arrays

Add missing types

• fixed
• functions

Add uint and int alias

Decoding: check if contentSize == params.size - 1

Check if the return is not malformed. Throw an exception if it is (ie.: the condition in the title doesn't hold)

Add decode function to solidity types

remove android dependency

currently it depends on the android gradle plugin and is tightly coupled to android. This plugin might also be useful outside the android scope. So it would be great if the android dependency could be dropped or optional.

Generate code for events

Handle nested arrays of static types

Make decoding of bytes more robust

Some abi encoder encode empty bytes as
0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 (length = 0 and an 0-bytes body)

bivrost is expecting 0x0000000000000000000000000000000000000000000000000000000000000000

we make use of this assumption when decoding tuples. Therefore we will have unexpected results if we try to decode tuples that contain the "padded" encoding.

The solution would be to parse the position of each dynamic type and jump to that position for decoding.

Add encoding and decoding of constructors and option to include deployment data

It would be really useful to be able to create deployment transactions. For this the deployment code (init code) is required and it should be possible to encode the constructor data.

Another useful feature would be to decode constructor data, so that deployment transactions can be analysed.

As this are potentially large strings that are copied into code it should be possible to deactivate this as a compiler flag (or even better specify the contracts that should include their deployment data)

Add JUnit tests for encoding/decoding each Solidity type