a-b-r-o-w-n/eslint-action

Github action that lints changed files.

Eslint Annotate

Runs eslint on changed files and creates inline annotations with errors.

Usage

In .github/workflows/main.yml:

name: Example Workflow

on: [pull_request, push]

jobs:
  lint:
    steps:
      - uses: actions/checkout@v1
      - uses: a-b-r-o-w-n/eslint-action@v2
        with:
          repo-token: "${{ secrets.GITHUB_TOKEN }}"
          files: "src/**/*"
          ignore: "src/some-file-to-ignore.js"
          extensions: ".js,.ts"
          working-directory: "./my-package"
          quiet: "false"

eslint-action's Issues

Error loading modules

Hi,

I'm trying to use this action but I'm getting an error loading a module. My React Typescript application is not located in the root. So I use the following argument to point in the right path:

 files: src/Unosquare.AssetCore.Server/client-app/src/**/*

It seems like eslint is finding my config file but not the related modules declared:

##[error]Failed to load plugin 'react' declared in 'src/Unosquare.AssetCore.Server/client-app/.eslintrc.js': Cannot find module 'eslint-plugin-react'

The node_modules folder is restored before to use this GH Action.

Thanks!

check endpoint requires GitHub App

The endpoint of checks requires a GitHub app. Couldn't find the docs about how to do so, my other alternative is to fork this action and app authentication to the code. What am I missing?

feat: support --quiet option

Warnings are currently ignored. Instead, it should be configured using the eslint option quiet to report warnings as annotations.

lint changed files on push

Currently, on pull_request event is supported.

Question: Should annotations persist after issues are resolved?

Thanks for your hard work! This was the only GitHub action that works for me in a mono-repo where working-directory is not the repository root. :)

When all lint issues are solved, the annotations for the failed lines persist, even when I re-run tests.

I'm not sure if this is an issue with my workflow file or intended behavior:

      - name: Save Code Linting Report JSON
        run: npm run lint:report
        continue-on-error: true

      - name: Annotate Code Linting Results
        uses: ataylorme/[email protected]
        with:
          repo-token: "${{ secrets.GITHUB_TOKEN }}"
          report-json: "backend/eslint_report.json"
      - name: Upload ESLint report
        uses: actions/upload-artifact@v2
        with:
          name: eslint_report.json
          path: backend/eslint_report.json

error when eslint doesn't match any files

When I delete one file from the repo in PR I get this error. The file I deleted was src/image.png

##[error]No files matching 'src/image.png' were found.
8
##[error]Node run failed with exit code 1

my options

repo-token: ***
files: src/**/*
extensions: .js,.jsx,.ts,.tsx
ignore: **/node_modules/**

handle when action triggered on a PR from a fork

Things to consider:

• add logging
• still run linter
• output results to console instead of creating annotations

Update to Node.js 16

Getting this error in my workflows:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: a-b-r-o-w-n/[email protected]. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Can we just code update this to 16?

eslint-action/action.yml

Lines 26 to 28 in 542dd7a

	runs:
	using: "node12"
	main: "lib/index.js"

Happy to do that via a PR.

cc @jimvandervoort