a11n/customlintrules

A basic, Gradle-based project template for writing custom Android Lint rules.

customlintrules's Issues

Simplify HelloWorldDetector

The purpose of HelloWorldDetector is to provide a basic Detector class which showcases a common Detector structure, such as definition of Issue, restriction of files/elements/attributes and so forth.

That's why getApplicableElements() is overwritten at first. It should demonstrate how to restrict elements to analyze and to use SdkConstants for that purpose.

However, at a second glance this is somehow misleading. By overwriting getApplicableElements() it is also required to overwrite visitElement():

If non null, this detector will be called (specifically, the {@link #visitElement} method) for each matching element in the document.

Since the evaluation part is done in visitAttribute in the current implementation visitElement does nothing.

In order to provide a clean example this should be refactored since it might be misleading.