aanand/compose-file

Parser for the Compose file format (version 3)

compose-file's Issues

attachable property not supported in network definition

Is this the official parser for the compose v3 file as used by docker? In docker-compose 1.10 rc2 all networks created by docker-compose are attachable. docker deploy though does not do this and does not recognise the attachable property.

Improve version compare

Noticed this while reviewing moby/moby#28297 (comment)

The version compare added in 1fb3703 will break once compose-file versions 3.1 or 4.x become available. For 4.x, that may be intentional, but it should probably not break for 3.1.

This could be used instead; https://github.com/docker/docker/blob/master/api/types/versions/compare.go (or a similar approach)

/cc @vdemeester @aanand

template test failures

With github.com/stretchr/testify v1.2.1 template tests fail as follows:

=== RUN   TestEscaped 
--- FAIL: TestEscaped (0.00s) 
        template_test.go:21:  
                        Error Trace:    template_test.go:21 
                        Error:          Received unexpected error: 
                                        <nil> 
                        Test:           TestEscaped 
=== RUN   TestInvalid 
--- PASS: TestInvalid (0.00s) 
=== RUN   TestNoValueNoDefault 
--- FAIL: TestNoValueNoDefault (0.00s) 
        template_test.go:46:  
                        Error Trace:    template_test.go:46 
                        Error:          Received unexpected error: 
                                        <nil> 
                        Test:           TestNoValueNoDefault 
        template_test.go:46:  
                        Error Trace:    template_test.go:46 
                        Error:          Received unexpected error: 
                                        <nil> 
                        Test:           TestNoValueNoDefault 
=== RUN   TestValueNoDefault 
--- FAIL: TestValueNoDefault (0.00s) 
        template_test.go:54:  
                        Error Trace:    template_test.go:54 
                        Error:          Received unexpected error: 
                                        <nil> 
                        Test:           TestValueNoDefault 
        template_test.go:54:  
                        Error Trace:    template_test.go:54 
                        Error:          Received unexpected error: 
                                        <nil> 
                        Test:           TestValueNoDefault 
=== RUN   TestNoValueWithDefault 
--- FAIL: TestNoValueWithDefault (0.00s) 
        template_test.go:62:  
                        Error Trace:    template_test.go:62 
                        Error:          Received unexpected error: 
                                        <nil> 
                        Test:           TestNoValueWithDefault 
        template_test.go:62:  
                        Error Trace:    template_test.go:62 
                        Error:          Received unexpected error: 
                                        <nil> 
                        Test:           TestNoValueWithDefault 
=== RUN   TestEmptyValueWithSoftDefault 
--- FAIL: TestEmptyValueWithSoftDefault (0.00s) 
        template_test.go:69:  
                        Error Trace:    template_test.go:69 
                        Error:          Received unexpected error: 
                                        <nil> 
                        Test:           TestEmptyValueWithSoftDefault 
=== RUN   TestEmptyValueWithHardDefault 
--- FAIL: TestEmptyValueWithHardDefault (0.00s) 
        template_test.go:75:  
                        Error Trace:    template_test.go:75 
                        Error:          Received unexpected error: 
                                        <nil> 
                        Test:           TestEmptyValueWithHardDefault 
=== RUN   TestNonAlphanumericDefault 
--- FAIL: TestNonAlphanumericDefault (0.00s) 
        template_test.go:81:  
                        Error Trace:    template_test.go:81 
                        Error:          Received unexpected error: 
                                        <nil> 
                        Test:           TestNonAlphanumericDefault 
FAIL 
FAIL    github.com/aanand/compose-file/template 0.004s 

Please update for Docker 18.03.1

This library FTBFS with recent version of Docker client.
The following patch appears to fix the problem:

--- a/loader/loader.go
+++ b/loader/loader.go
@@ -11,9 +11,9 @@

        "github.com/aanand/compose-file/interpolation"
        "github.com/aanand/compose-file/schema"
        "github.com/aanand/compose-file/types"
-       "github.com/docker/docker/runconfig/opts"
+       "github.com/docker/cli/opts"
        units "github.com/docker/go-units"
        shellwords "github.com/mattn/go-shellwords"
        "github.com/mitchellh/mapstructure"
        yaml "gopkg.in/yaml.v2"

How to convert a compose file ?

I am able to compile the code, but not able to understand where shall I provide my compose file to convert it into json.
Could anyone tell me how it can be done?

README file

Can we have a readme listing down usage examples and contributing guide

warn on network.ipv4_address (and network.ipv6_address)

ipv4/6_address are not supported by swarmkit yet, but we don't warn when they are included in a file.

cc @aanand @vdemeester