aatarasoff/spring-thrift-starter

Set of cool annotations that helps you building Thrift applications with Spring Boot

spring-thrift-starter's Issues

Add hystrix support

Add optional hystrix wrapper around thrift service calls.
It'll be great if optional toObservable() method will exists during compile time (dont know how to implement in java, analogue of mixin in groovy and scala).

Implement SpanInjector and SpanExtractor patterns

LoggingThriftMethodInterceptor exception wrapping

Hi! I see that LoggingThriftMethodInterceptor wraps any exception into a TApplicationException in afterThrowing(), TApplicationException being a checked exception. I did a small refactoring of that class and have just left this code as it was. But now it's bothering me. If my callee code results in some runtime exception, the exception chain gets ugly: SomeRuntimeException -> TApplicationException -> java.lang.reflect.UndeclaredThrowableException: null (!) -> org.apache.thrift.transport.TTransportException: HTTP Response code: 406

Maybe it's worth changing the exception type to some runtime exception subclass? The problem is, all libthrift exceptions are checked.

New client bean registration logic doesn't work

Here you register bean with name, which is generated by getBeanName method.
But later get bean from context by simple type name.
This two names are different, that's why you don't use registered bean and anyway go to else case.
It brakes mocking client bean

End-to-end forwarding "x-request-id" HTTP Header

Is socket client connection supported？

I want to use TSocketClient

Add timeouts for Thrift clients

NullPointerException in TLoadBalancerClient

Exception occurs when there is no service with such name in service registry.
Here:

HttpURLConnection iox = 
    (HttpURLConnection) new URL(this.loadBalancerClient.choose(serviceName)
        .getUri().toString() + path).openConnection();

loadBalancerClient.choose(serviceName) returns null.

https://github.com/aatarasoff/spring-thrift-starter/blob/60bab1f92fca926ade509a36961a468a62f4d3df/autoconfigure/src/main/java/info/developerblog/spring/thrift/transport/TLoadBalancerClient.java

Still maintained?

Is this package still maintained?

We are looking into using something similar but would like to extend e.g. the collected metrics and I was curious if it made sense to trying to contribute or if simply forking might be the easier option.

spring-thrift-starter:1.5.0 does not exists in jcenter

the latest release in jcenter is 1.4.0.RELEASE

Not so active the project is

Is there anyone apply this in production?

Could not find org.apache.thrift:thrift:0.9.2 for windows

spring-thrift-starter/examples/test-protocol/build.gradle

Line 52 in 16853e3

def thriftVersion = '0.9.2';

For WINDOWS available version 0.9.1 - http://dl.bintray.com/bsideup/thirdparty/

Migrate from @ThriftHandler to @ThriftController notation

Migrating to Spring Boot 1.3.x

Support for new version of Spring Boot framework