Giter Site home page Giter Site logo

Make MAX_LINE configurable about websockets HOT 5 CLOSED

dangeReis avatar dangeReis commented on September 7, 2024 1
Make MAX_LINE configurable

from websockets.

Comments (5)

aaugustin avatar aaugustin commented on September 7, 2024 1

Fixed in bbb3161.

Please be aware that, if you are currently monkey-patching MAX_LINE, that will break in version 13.0. You will have to set the WEBSOCKETS_MAX_LINE_LENGTH environment variable instead.

from websockets.

teamclouday avatar teamclouday commented on September 7, 2024

Yea I'm facing the same issue. The cookie line is longer than MAX_LINE.
What's weird is that I configured withCredentials: false in socketio client but it still gets sent in the header. I also tried to configure fastapi middleware but the cookie wasn't found in the request. Not sure if this is an issue with websockets or socketio

from websockets.

aaugustin avatar aaugustin commented on September 7, 2024

The best answer I have right now is still this one: #1243 (comment)

from websockets.

aaugustin avatar aaugustin commented on September 7, 2024

I just made a change that gives you a slightly better error message in that case:

Failed to open a WebSocket connection: did not receive a valid HTTP request; line too long.

from websockets.

aaugustin avatar aaugustin commented on September 7, 2024

I'm going to make it configurable via an environment variable.

from websockets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.