Clean up tests on PyPy

[aaugustin]

Clean up tests on PyPy

[aaugustin]

Frequent warning:

~/.pyenv/versions/pypy3.10-7.3.16/lib/pypy3.10/asyncio/sslproto.py:320: ResourceWarning: unclosed transport <asyncio.sslproto._SSLProtocolTransport object at 0x...>

Test failure not linked to a specific test, but to the framework:

Traceback (most recent call last):
  File "/Users/myk/dev/websockets/tests/legacy/test_client_server.py", line 122, in _decorate
    return func(self, *_args, **_kwargs)
  File "/Users/myk/dev/websockets/tests/legacy/test_client_server.py", line 121, in _decorate
    with manager(self, *args, **kwargs):
  File "/Users/myk/.pyenv/versions/pypy3.10-7.3.16/lib/pypy3.10/contextlib.py", line 135, in __enter__
    return next(self.gen)
  File "/Users/myk/dev/websockets/tests/legacy/test_client_server.py", line 105, in temp_test_client
    test.start_client(*args, **kwargs)
  File "/Users/myk/dev/websockets/tests/legacy/test_client_server.py", line 331, in start_client
    super().start_client(path, **kwargs)
  File "/Users/myk/dev/websockets/tests/legacy/test_client_server.py", line 266, in start_client
    self.assertDeprecationWarnings(recorded_warnings, expected_warnings)
  File "/Users/myk/dev/websockets/tests/legacy/utils.py", line 80, in assertDeprecationWarnings
    self.assertEqual(type(recorded.message), DeprecationWarning)
AssertionError: <class 'ResourceWarning'> != <class 'DeprecationWarning'>

Failed run with that error: https://github.com/python-websockets/websockets/actions/runs/10316111205/job/28558214475

[aaugustin]

I doesn't make sense to spend much time fixing the test suite for the legacy implementation under PyPy, though.

[aaugustin]

This warning is a bug: python/cpython#90476

It was fixed in Python 3.11.

I tried to remove it by adding this to tests/__init__.py:

import warnings
warnings.filterwarnings(action="ignore", category=ResourceWarning)

This filters out ResourceWarning. I could confirm by raising a ResourceWarning just after this line. However, the warnings still get raised later in the tests. Probably something changes the warning filters inbetween. I just don't know what.

Removing warnings with command line arguments (pypy3.9 -W ignore:"unclosed transport":ResourceWarning:asyncio.sslproto -m unittest) works but that's quite annoying and hard to make conditional on the Python version. Very messy.

[aaugustin]

After 1853a9b tests are passing again on GitHub Actions — after a long string of non-passing tests. I couldn't get rid of the warning; I'll live with it.