aave-starknet-project/aave-starknet-bridge

Bridge aTokens to Starknet

aave-starknet-bridge's Issues

Update l2 state on withdraw

Update deposit of token_bridge to do conversion of token and aToken

Change approval mapping from staticAToken to aToken

get_pending_rewards on claimable returns a null value

aave-starknet-bridge/test/ETHStaticAToken.test.ts

Line 168 in 57a968d

const user1PendingRewards = await l2token.call("get_user_pending_rewards", {

use prettier consistently for solidity, ts, js (and cairo?)

Test rewards claiming

Create release/v1 branch

Once PR #120 is merged, we should do three things:

• add addresses of deployed contracts to README,
• create a branch named release/v1 from where contracts have been deployed on Ethereum and Starknet,
• and create a release tag associated to this branch.

Rewards withdrawal

Currently with drawing rewards faces the problem that the rewards are accrued from a number of different sources but indicated by a single token. As a result a user bridging their rewards back to L1 may have accrued it from any collection of pools.

The bridge will own all the rewards across all the staticATokens required to cover the bridged rewards however it won't know which staticAToken to claim rewards from in order to cover the value of the rewards bridged.

There are a number of strategies here:

1. Allow the bridging user to specify which tokens to claim from:
   - Any amount of rewards which couldn't be claimed by the addresses passed can be added onto the recipients unclaimed rewards
2. Maintain an ordered list of l1 tokens to claim against and do so until the total reward is collected
3. Same as 2 but do something a little smarter like selecting a random order for the tokens to claim against

update l1 bridge to call IncentivesController for rewards claiming

add deposit/withdrawal events to l2 token_bridge

use andreys staticATokenLM (link coming)

Add requirements.txt for python dependencies

On the Cairo file in L1 folder

In this file , why you set BRIDGE_REWARD_MESSAGE = 1 and the other message as 2 ?

How do your team think about such message passing ?

replace bridge current proxy with aave proxy

get rid of starkgate proxy and use instead:

• https://github.com/aave/aave-v3-core/blob/master/contracts/dependencies/openzeppelin/upgradeability/InitializableAdminUpgradeabilityProxy.sol
• https://github.com/aave/aave-v3-core/blob/master/contracts/protocol/libraries/aave-upgradeability/VersionedInitializable.sol

update swapnil's package to use latest version of L1 StaticATokenLM contract

add verify deployed contracts script

use factory to deploy proxies

we can use a factory created by BGD to deploy mainnet proxies:

• the code of the factory is here: https://github.com/bgd-labs/solidity-utils/blob/main/src/contracts/transparent-proxy/InitializableAdminUpgradeabilityProxyFactory.sol
• once deployed, the factory address will be here: https://github.com/bgd-labs/solidity-utils/tree/main/src/deployments

Replace mentions of 'ethereum' and 'starknet' with 'l1' and 'l2'

Extend staticATokenLM with messages to ETHStaticAToken on L2 include a trigger to send an update at any time

PR here: https://github.com/kyzia551/protocol-v2/pull/2/files

Pass `_accRewardsPerToken` and `blocknumber` with deposit

• add staticAToken implementation from Andrey
• send message from transfer function of staticAToken
• add blocknumber in token bridge message
• receive messages on ETHStaticAToken side

Rename accRewardsPerToken to index

test: ensure that rewards are not lost if we do not claim them

Add proxy support to TokenBridge

Update docs (find aave docs and add there or write something comprehensive for the readme)

Finish claiming on l2 - we need to make a claim against the ETHstaticAToken to go through the bridge to mint the rewards from the rewAAVE token

Manual update of l2 state

enrich CI (static analyzer for solidity and cairo, cache node dependencies, cache python dependencies)

we plan to add two static analyzers in the CI:

• one for cairo: https://github.com/crytic/amarna
• one for solidity: https://github.com/crytic/slither

talk to devnet people

this thread is insightful about future improvements

add verify deployed contracts script

use _getCurrentRewardsIndex as index in StaticATokenLM

pull request: https://github.com/kyzia551/protocol-v2/pull/4/files

write deployment scripts

test: check rewards minted by staticAToken match the old implementation