aave/aave-v3-periphery

aave-v3-periphery's Issues

Fix Incentives Controller with low decimal tokens

Low decimal tokens can cause an overflow at the index due the IncentivesController is fixed to work with 18 decimals at the index level.

The fix should allow low decimal tokens to be supported by the Incentives Controller contract.

UiIncentiveDataProviderV3 breaks if vTokens have zero incentives controller

If vTokenIncentiveController is zero, the following call will revert.

aave-v3-periphery/contracts/misc/UiIncentiveDataProviderV3.sol

Lines 105 to 111 in 0e7b7d9

	);
	// Get vTokens rewards information
	IRewardsController vTokenIncentiveController = IRewardsController(
	address(IncentivizedERC20(baseData.variableDebtTokenAddress).getIncentivesController())
	);
	address[] memory vTokenRewardAddresses = vTokenIncentiveController.getRewardsByAsset(

Add isolation fields to UiPoolDataProvider

Add BORROWABLE_IN_ISOLATION_MASK and userConfig.getIsolationModeState to UiPoolDataProvider getters

How should I deploy the UiPoolDataProviderV3 and UiIncentiveDataProviderV3 contracts?

Add control to block mints in Faucet contract

Add ability to CollectorController of controlling multiple collectors

Remove the immutable COLLECTOR variable and pass it to each function.

Same approach as AaveEcosystemReserveController for Ethereum controller. (link)

1CAT

Add migration scripts for Aave market deployment

Add ability to deploy an Aave market pulling core contracts from their repo

Add incentives controller to aave-v3-periphery

Add the incentives controller to the aave v3 periphery deployment and set the incentives controller in the aTokens and debt tokens with the setIncentivesController() function

Tokens with no return value from `approve` function do not work with v3 paraswap adapters

Tokens that do not return a value from the approve function do not work with the paraswap adapters, such as USDT. Currently, GPv2SafeERC20 is being used to wrap ERC20s, but there is no approve in the library.

Look at using OZ's SafeERC20 which handles no return value, and assumes it is successful if there is no revert.

Calling DefaultReserveInterestRate functions can fail since not all strategies comply with its interface

This will revert when dealing with simpler interest rate strategies (eg. GHO)

aave-v3-periphery/contracts/misc/UiPoolDataProviderV3.sol

Lines 150 to 155 in 0e7b7d9

	InterestRates memory interestRates = getInterestRateStrategySlopes(
	DefaultReserveInterestRateStrategy(reserveData.interestRateStrategyAddress)
	);
	reserveData.variableRateSlope1 = interestRates.variableRateSlope1;

ParaSwapRepayAdapter cannot repay with same asset

When a user has collateral and borrow position of the same asset, they aren't able to repay with this adapter since it attempts to swap the asset for itself.

This isn't an issue in V3 because of the repayWithATokens feature, but in V2, users can be locked into leveraged positions because of this

Add old parameters to the `AssetConfigUpdated` event

To keep consistency with the implementation of the configuration events in core V3, the old values should be emitted in the AssetConfigUpdated event.

Rename lending pool with pool in UiIncentiveDataProviderV3 contract

In V3 there is no more LendingPool, but Pool instead.

IRewardsController.handleAction() function is wrong (parameters do not match)

Parameters of the IRewardsController,handleAction():

  function handleAction(
    address user,
    uint256 userBalance,
    uint256 totalSupply
  ) external;

Parameters of the RewardsController,handleAction():

  function handleAction(
    address user,
    uint256 totalSupply,
    uint256 userBalance
  ) external override {
    _updateData(msg.sender, user, userBalance, totalSupply);
  }

RewardsDistributor does not need a constructor to init the emission manager

The value of the emissionManager variable is initialized in the constructor. This is not needed due to the fact that this contract is behind a proxy and there is a setter for it.

New UiPoolDataProvider params

Add new params to the UiPoolDataProvider so we have all the information necessary for the new v3 logic and calculations on the libs / clients / apis

Remove `LendingPool` references

Rename LendingPool to Pool

Add last version of AaveEcosystemReserve from Level 2 Adjustment proposal

With the execution of the proposal #107, the Aave Ecosystem Reserve contract has been upgraded.

Source code

Add the paraswap swap and repay adapters to aave-v3-periphery

Add the deployment of the paraswap adapters to v3 periphery. In aave-v3-deployments, let the deployer choose whether or not these should be deployed.

Remove outdated buidler references

Remove any reference to the previous name of hardhat: buidler

Add function to adjust only the emission per second

The rewards controller is missing a function to change only the emission per second. This function should take an array of assets as input and also update the asset data of each asset being adjusted.

Add new UiIncentiveDataProvider for v3

Add periphery contracts removed from core

Add the following periphery contracts:

• UI data providers
• WETH gateway
• wallet balance provider

Emission manager contract to control reward emissions

The RewardsController allows to have multiple rewards distributions at the same time, but there is only 1 emission manager.
We need to add more granular permissioning to the manager role of the emissions.

Update Ecosystem Reserve contracts

With the execution of the proposal #71, the Aave collector contract has been upgraded. These contracts needs to be added or updated in the repo.

Source code

I noticed this one:

I noticed this one:

-    df["category"] = Series(
-        np.array(list("abcdefghij")).take(np.random.randint(0, 10, size=n))
-    ).astype("category")
+    df["category"] = (
+        Series(
+            np.array(list("abcdefghij")).take(np.random.randint(0, 10, size=n))
+        ).astype("category")
+    )

which I realize is another example of what you meant by 2.

Originally posted by @JelleZijlstra in psf/black#3368 (comment)

Add UiIncentivesProvider helper contract

Add the UiIncentivesProvider helper contract to the v3 periphery repo

Gas golfing the incentives controller

The incentives controller logic needs to be refactored to reduce gas impact. The following can be applied

• Pack userIndex and accrued rewards together to reduce the storage footprint
• Get rid of two of the three events in the handleAction function and group all the data emitted in one event
• Simplify calculations, use unchecked for loops