abdenasser/dr_scaffold

scaffold django rest apis like a champion 🚀

Hi there 👋

I’m Abdenasser Elidrissi, a Software Engineer from Morocco, I love coffee and computers and I am passionate about bringing ideas to life. I’m a Senior Backend Engineer during the day (at Obytes), and an indie maker by night.

dr_scaffold's Issues

Add max_digits and decimal_places on DecimalField

Issue Summary

In DecimalField max_digits=5, decimal_places=2, is essential.

---

If this is a bug instead of a question or feature request, please fill out the sections below.

---

Steps to Reproduce

This parameters is mandatory to make migrations.

What were you expecting to happen?

Add max_digits=5, decimal_places=2, on DecimalField.

Message error

In my example:

SystemCheckError: System check identified some issues:

ERRORS:
ecommerce.OrderItems.price: (fields.E130) DecimalFields must define a 'decimal_places' attribute.
ecommerce.OrderItems.price: (fields.E132) DecimalFields must define a 'max_digits' attribute.

Suggestion: rename create_date field to created

I suggest rename create_date to created.

Because if you want to use (CursorPagination)(https://www.django-rest-framework.org/api-guide/pagination/#cursorpagination) you need of the created field. And particularly I find this a more conventional name.

Suggestion: return a representation of the model

How about returning a representation of the model?

Ex:

def __str__(self):
    return self.name_of_the_first_field

Bug: Error: ImproperlyConfigured at /blog/posts/

Error: ImproperlyConfigured at /blog/posts/
Could not resolve URL for hyperlinked relationship using view name "user-detail". You may have failed to include the related model in your API, or incorrectly configured the `lookup_field` attribute on this field.

Describe the bug

This error occurs when entering the route.

To Reproduce
Steps to reproduce the behavior:

1. Go to '/blog/posts/'

Additional context

Sugestion

Resolve this bug or change serializers.HyperlinkedModelSerializer for serializers.ModelSerializer.

Fix second argument on the command line to remove special character

If type python manage.py dr_scaffold blog Article: title:char body:text

type : before or after model name

This generate

class Article:(models.Model):
    title = models.CharField(max_length=255, null=True, blank=True)
    body = models.TextField(null=True, blank=True)
    create_date = models.DateTimeField(auto_now_add=True)

    class Meta:
        verbose_name_plural = "Article:s"

Article with two points.

Suggestion

Address this in the argument on command line.

Some types of fields are required.

Field description