abdullahobaid/mobilyws-laraval

A Laraval package to send SMS using Mobily.ws API

mobilyws-laraval's Issues

Performance issue

Hi AbdullahObaid,
Thanks for your great job!

If you allow me I have a suggestion in Mobilyws-Laraval/src/Mobily.php

public static function Send($numbers, $msg, $dateSend = 0, $timeSend = 0)
{
 .
 .
 .
if ($result == 5) {
   return trans('mobily.wrondpassword');
}
.
.
elseif ($result == 1) {
     return true;
  }
} 

You should make if conditions by common case, you don't need go through all conditions many times!
for example let make it like that:

if ($result == 1) { return true;} 
elseif ( ... ) { ... }

It becomes at the first condition, because it is our common case .. and so on!
If we have billions massages it will be much better than current way.

Best regards M. Saud 🤠

Problem with sending SMS

Salam,

Seems like mobily are changed their API

How to use apiKey (mobily.ws) instead of mobile and password, please help me?