abelkrijgtalles/mojang-maps

A Google Maps like navigation system for Minecraft.

Projects I've finished:

• Mojang Maps (Pretty far, but not 100% completed)

"It would be easier to design my own cpu and bios and create my own OS than learning the basics of a boot sector and other things."

GPG Public Key

mojang-maps's Issues

[BUG] Player gets sent empty actionbar message when not over a road.

When a player moves and they are not over a road they get sent an empty actionbar message, this results in any other actionbar messages being overridden.

The problematic code is:

mojang-maps/src/main/java/nl/abelkrijgtalles/MojangMaps/listener/PlayerWalkListener.java

Line 46 in 33a2a71

p.spigot().sendMessage(ChatMessageType.ACTION_BAR, new TextComponent(RoadUtil.getLocationMessage(p)));

A simple fix would be:

String roadMsg = RoadUtil.getLocationMessage(p); // ask the RoadUtil for the location message
if (roadMsg != "") { // check if the message is not empty
       p.spigot().sendMessage(ChatMessageType.ACTION_BAR, new TextComponent(roadMsg)); // send the message like before
}

or you could read the action bar by using packets and let other actionbar messages take priority.

[Feature/Bug]: Allow to specify multiple lanes for a road.

Some roads may be more complicate than others, for example:

Using a command like /createroad Main_Street -129 -5 524 -129 -4 439 -129 -4 374 -133 -4 364 -137 -3 355 -139 -3 350 -139 -3 276 -129 -3 263 -129 -2 210 won't be enough because for some lanes the actionbar at the bottom believes your not on a road (because its too wide).

Maybe we can create an empty road like /createroad Main_Street then use /addlane Main_Street TYPE -129 -5 524 -129 -4 439 -129 -4 374 -133 -4 364 -137 -3 355 -139 -3 350 -139 -3 276 -129 -3 263 -129 -2 210. The TYPE parameter could be "Driving" or "Walking", it won't serve much use now, however, it will be beneficial to differentiate the types of a lane (could be useful for a Web UI in the future or other plugins that want to extend MojangMaps). In addition some servers may have a vehicle mod installed (like I do) so speficiying the type of the lane would mean you won't get people being told to walk in the middle of a road.

Using the hypothetical /addlane will mean we can define multiple lanes which we can class as the same road.

[Feature]: Could You Port The Mod to Fabric too? (to Fabric Servers)?

The "Currently on:" message still displays 25 blocks south of a location

The "Currently on:" message still displays 25 blocks south of a location.
Images:

Languages with xx-XX codes can't be used

These are the current languages that can't be used by that error

• Spanish
• Latin
• Portuguese, Brazilian
• Portuguese
• Swedish
• Chinese Simplified
• Chinese Traditional
  This is because Mojang Maps tries to download https://raw.githubusercontent.com/Abelkrijgtalles/mojang-maps-data/main/xx-XX/xx-XX.json instead of https://raw.githubusercontent.com/Abelkrijgtalles/mojang-maps-data/main/la-LA/la.json
  This results in this error:
  Could not download file from https://raw.githubusercontent.com/Abelkrijgtalles/mojang-maps-data/main/xx-XX/xx-XX.json to plugins\MojangMaps\messages.json.
  The code that is responsible for this error is:
  

  mojang-maps/src/main/java/nl/abelkrijgtalles/MojangMaps/util/file/TranslationUtil.java

  Line 76 in 8f5108d

  HTTPUtil.DownloadFile("https://raw.githubusercontent.com/Abelkrijgtalles/mojang-maps-data/main/%s/%s.json".formatted(languageCode, languageCode), String.valueOf(Paths.get(String.valueOf(Bukkit.getServer().getPluginManager().getPlugin("MojangMaps").getDataFolder()), "messages.json")));

Server crashes after adding too many locations

Just adding this for the release and a branch. It's usually with 150+ locations.