abo-abo/eclipse-theme

Eclipse theme for Emacs

eclipse-theme's Issues

[question] Do this theme have dark version?

Thanks for another awesome package again.

Personally I use light theme in the daytime and dark theme in the night. Eclipse theme is the most comfortable theme for my eyes among many light themes. I wonder if there is a dark one and want to find a reference so that I can implement an eclipse-dark-theme myself (or maybe someone else had done this before ? )

Border between windows?

First of all, thanks for a very tasteful theme.

I am running Ubuntu 22.04 and I have the issue that the border between windows is not very visible as seen below:

As a quick fix, I added the definition (eclipse-fringe "grey90") and change the fringe setting to be (fringe :background ,eclipse-fringe). If I do that, it is easier to see the border but ideally I would like the background of the actual scrollbar to be grey rather than the fringes:

Does anyone have a suggestion how to improve the border visibility between the windows apart from my hack above? Is there another setting than fringe that can be tweaked?

End of line styling conflict with default behavior in Magit buffer.

Hi, as it was reported yesterday new lines style has a conflict with default behavior.

Looks like Magit buffers needs additional attention.

Package version: 20191112.1008

Have a good day 🎉

Best regards,
Artem.

dejavu is good, but

I believe font-settings should not be included into theme:

 `((default :family "DejaVu Sans Mono"
              :height 113
              :foreground ,eclipse-fg
              :background ,eclipse-bg)

I use source code pro and don't have dejavu installed thus eclipse-theme makes funky job with my emacs :)

Add code to auto add to color themes path.

;;;###autoload
(and load-file-name
     (boundp 'custom-theme-load-path)
     (add-to-list 'custom-theme-load-path
                  (file-name-as-directory
                   (file-name-directory load-file-name))))

End of line styling conflict with default behavior.

Hi, thanks for the awesome theme!

Some time ago styling of the end of lines changed for me.

It was:

It is now:

My emacs version:

GNU Emacs 27.0.50
Copyright (C) 2019 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GNU Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.

I believe there was some thread about that on the Hacker News.

Is it possible to support both styles in the theme?

Have a good day 🎉

Best regards,
Artem.

Weird color in minibuffer

I like your theme, nice work. You can guess that I too use eclipse a lot.

Couple of suggestions:

1. I have global-hl-line-mode enabled, and the default line highlight color is a bit too dark for comfortable viewing of the text. This might happen for other users as well.

Currently I am not sure whether this is due to the theme settings or some of my packages. So I override it with
(set-face-background 'hl-line "#e5e4e2") ;; platinum color

2. The minibuffer completion shows red color when narrowing down the list. Here is a snapshot, I am not sure whether this is by design.

Why the plain face for outline-2?

Came to this theme from your screencasts, enjoy it very much. Don't you get confused in org-mode when the second heading is indistinguishable from body text? Feel like they could be visually distinguished more.

Powerline Mode Line

I am on Mac OSX Sierra I installed eclipse theme along with powerline font Dejavu Mono, but my modeline still looks normal.

Is there anything else I need to do, I like the power line fonts in the mode line.