abodehq/azir

azir ui kit

azir's Issues

Invalid Hooks Handling

There is a bug resulting from the following code:
https://github.com/abodehq/azir/blob/master/azir-core/azir-slider/index.tsx

In the UseEffect you don't put the functions as a dependencies. As a result, the functions are not updating, although props such as disabled does update. For example, if you will create a disabled slider, you can't enable it.

You need to use useCallback and to add methods to the dependency list of the useEffects

azir-Slider does not update after the first render

When using the example for the azir-slider:

import Slider from "azir-slider";
---
<Slider
  value={30}
  step={10}
  minimumValue={0}
  maximumValue={100}
  onStart={value => console.log(value)}
  onChange={value => console.log(value)}
  onComplete={value => console.log(value)}
  trackColor="red"
  thumbColor="blue"
  progressTrackColor="green"
  thumbSize={50}
  trackSize={30}
/>

it works like in the example.
when changing the value field to this.state.position the slider is stuck at the first value given.
logging the this.state.position in the render function shows it gets updated.

Azir slider "jumps" to value on render

When screen starts, slider "jumps" to value instead of rendering on selected value.
GIF here:
https://user-images.githubusercontent.com/12761818/70825181-1f1d8a00-1de4-11ea-9eab-0963f61a6111.gif