abraker95/osu-api-cpp

A C++ API for interfacing with the Osu API: https://github.com/peppy/osu-api/wiki

osu-api-cpp's Issues

Make filenames follow one naming convention

Use jsoncpp for JSON parsing

Library Documentation

Because I accidentally deleted it

Does not work as intended when compiling with Visual Studio's Release Confguration

The data contents end up being blank.

I believe the root cause has to do something with the downloader. Upon closer examination using debugging tools, I've found that the URL is not being properly read as soon as the debugger enters download.cpp. Passing it as a string didn't help either as I am suspecting it gets lost during the typecast to a char*.

Line(s) of code suspected:
Download.cpp: 60 - 73

Use better Enums

Sugestion by Soinou (https://osu.ppy.sh/forum/p/4199805)

Instead of something like:

params[U32 PARAM:game_mode] = "something";
params[U32 PARAM:limit] = 50;

you could do:

enum Parameter
{
    kGameMode = 0,
    kLimit = 1
}

params[Parameter::kGameMode] = "something";
params[Parameter::kLimit] = 50;

And your parameters could be defined in a map<int, string> or even better, in a custom class, where your [] operator would look like:

operator[] (Parameter param)
{
    switch(param)
    {
        case Parameter::kGameMode:
            // Handle game mode setter
            break;
        case Parameter::kLimit:
            // Handle limit setter
            break;
        default:
            break;
    }
}

Rename the project4 folder to something more relevant

Look into better data structure than the current vector<vector<string>>

Suggestion by Soinou (https://osu.ppy.sh/forum/p/4199805)

Something like an Osu::User that will contain all the informations parsed from the json.
For example:

namespace Osu
{
    struct User
    {
        long id;
        std::string username;
        ...
    }
}

This would be way better to understand and to use than a vector, and would be less prone to errors.

Make the static classes singletons