abtech/zulip_slack_integration

zulip_slack_integration's Issues

Update slack library

We are currently using a commit reference to the slack library to combat this bug: slackapi/python-slack-sdk#451 The newer releases should be checked for breaking changes, and our dependency version should be updated.

Link attachment truncate

I did not implement a truncation for link attachments. Cut off at 255 characters and add a ... is probably sufficient. However, it should be careful not to cut off other links found inside the attachment description text.

Slack link replacement

Slack links are not converted. Slack follows the syntax <http://xyz|my link text> and zulip uses traditional markdown links [my link text](http://xyz). I should note that it does not appear that users can create custom-text links, only slack itself and possibly bots (untested). User links seem to always appear as <http://xyz>.

I did not implement this quickly because it also must take into account code tags ``` and the inline variant.

Bot-generated message edits cause KeyError

Error looks like:

Oopsie! 2020-02-03 14:10:41,739 main ERROR Error receive slack message: ['Traceback (most recent call last):\n', ' File "/srv/zulip_slack_integrations/main/init.py", line 172, in receive_slack_msg\n user_id = data['user']\n', "KeyError: 'user'\n"],

This occurs after the following steps:

1. A message is bridged from zulip to slack containing a link, say from Imagur
   1a. (happens but not relevant) The bridge discards the reflected message, as it is generated by the bridge bot.
2. Another bot (or maybe slack itself?) decides the message needs to be edited to add an attachment, because the link points at something that is attachable.
3. This message is a message_changed subtype.
4. The brige handles message_changed by replacing the message with the contents of one of the subfields. However, in this case, this sub-field has a subtype of "bot_message"
   4a. We do not do the special handling of bot_message subtype before we try to access the user.
5. Error as above.

Slack keywords not always detected/replaced

There is some condition that causes @ and # to not be replaced properly sometime. Some sort of issue with the regex.

Image sent from groupme->slack comes with zulip formatting

Problem is obviously in this block of code, where images need to be treated differently for sending to slack.

https://github.com/ABTech/zulip_slack_integration/blob/7c292cbef51ca8e8889460327ccf72aab8768f48/__init__.py#L355:L363