acelikesghosts/ytm-rpc

a poorly made youtube music rpc

👋

i write instantly legacy and abandoned code

ytm-rpc's Issues

chore(extension): make better

look into and steal how premid does it
https://github.com/PreMiD/Presences/blob/main/websites/Y/YouTube%20Music/presence.ts

todo(extension): support non chromium browsers

todo(server): rewrite in TS

going to actually be taking this one myself and doing it ASAP

chore(extension): remove debug log

https://github.com/acelikesghosts/ytm-rpc/blob/master/chrome-extension/popup.js#L3

bug: direct swapping to a song does not update the RPC

code 5 == played = what we need

IDEA: "plugin" support to add features that are out of scope for the project

IE:

• Spotify spoofing
• Custom name/details/state (parsing)

etc

todo: add a proper share link in the `listen on YouTube Music` button

It may be necessary to reverse engineer the API to obtain a share link since it is not readily available on the page through scraping (IIRC)

FEAT REQ(Server): support for custom fields for name, detail, state, etc

not planned, simply an idea

bug(server): mass skipping songs hits the RPC rate limit which will kill the application

the discord-rpc library being used straight up KILLS the application if we hit a ratelimit, with a code 1000.

todo: add a rate limiter to the server ig

todo: stream line installation steps

Server Installation: 7 steps
Extension Installation: 4 steps
Client Mod: 5 steps

What we can do here is streamline the server installation and the client mod installation, most likely using a CLI.
The way I want to go for this will be something along the lines of the pseudo commands listed below:

git clone https://github.com/acelikesghosts/ytm-rpc.git
node ./scripts/streamline.js

Where streamline.js would provide a CLI to decide between the following:

1. Server Installation setup (install deps, using client mod, port)
2. Client mod (bd or replugged, automatically build and install it if chosen)
3. inform they have to add the extension manually

bug: setup script doesn't clone `.env.example`

feat(client-mods): add support for `vencord` and `replugged`

We already have support for BetterDiscord, so it is most likely in the best interests of the project to add support to both Replugged and Vencord

bug(extension): very first play does not display

bug(server): songs that are not on an album or are uploaded through normal YouTube will display the album as the view count

Instead of saying the amount of views, there should not be a state displayed.

todo(extension): remove jquery as a dep and use native `fetch` api

reduces bundle size and removes need to deal with legality of bundling it

bug: event listeners on `background` or `content` fire twice

attempting to resolve this on the refactor branch, alongside adding pausing of music being displayed;
have to fix the double sending (which is present in the master branch o.o) in order to add pausing.

double sending of the state causes the paused variable to flip flop because it sends the old state once and the new state once.

bug(client-mods): discord changes

they swapped from webpack to rspack, most likely will have to fix webpack searches.

bug(extension): pausing the song is not detected

????
Random ass bug, no clue why.

fix: remove testing log that's still in Chrome extension

https://github.com/AceLikesGhosts/ytm-rpc/blob/master/ChromeExtension/content.js#L20

bug(extension): storage onChange not polyfiled

b7f95ac

chore: remove the `.vscode` folder

No clue on how it got into the project, but it shouldn't be there.

bug(extension): mutation observer fires too fast while the song is still changing resulting in no song title or artist

When skipping songs fast(ish), it can result in the MutationObserver firing while the content is still loading, resulting in no song/artist being sent to the server.

bug: manifest has different id than the settings import

https://github.com/AceLikesGhosts/ytm-rpc/blob/master/client-mods/replugged/manifest.json#L2

should be all lowercase

bug: when starting a song directly it is believed to be paused

due to songs starting at a paused state, then automatically unpausing by YTM, the content script believes its paused; this is rather minor and can just be solved by pausing and unpausing the song, although its annoying.

todo: move from hard coded IDs (ex: `client_id`) to a `.env`

Use dotenv to migrate from hard coded IDs to just environment variables.

bug(client-mods): not using client ID set

https://github.com/AceLikesGhosts/ytm-rpc/blob/master/client-mods/BetterDiscord/src/index.jsx#L182

todo: make the Readme sections normal

why are they organized like that.

todo: rewrite readme

its a mess

chore(client-mod): remove debug log

https://github.com/AceLikesGhosts/ytm-rpc/blob/master/client-mods/replugged/src/index.ts#L66

todo(server): Add ability to communicate with BetterDiscord plugin in order to set status as `Listening to ...`

Will require:

1. Writing a BetterDiscord plugin which will connect to the server with a WebSocket
2. Writing the WebSocket code for the server

todo(extension): rewrite.

the src is painful to look at, no separation between the client script and the page script, etc etc

todo: make entire server script es5 or es6

most of it is es5, although there are a few parts which aren't. need to decide which to stick with

ex:
https://github.com/AceLikesGhosts/ytm-rpc/blob/master/index.js#L24-L26

feat(server): ability to spoof being spotify

This would involve the following:

1. Using a Spotify account token to fetch the song from Spotify in order to set the Artist URLs.
2. Setting the Application Id to 0
3. Setting the application name to "Spotify"
4. Providing a listen along ID/Token (spotify:UUID)

and prolly more

extension: data is posted without `album` being defined

every once in a while it will post data without the album text being defined.

todo: move replugged client-mod off of hard coded module id

module ids change a lot find a better way to find it in replugged

bug(updater): broken

what

chore(scripts): look into ways to load the extension via setup script

https://developer.chrome.com/docs/extensions/mv3/external_extensions/#preferences