achary/engimo

minimo-eng - Minimalist theme for Hugo tuned for engineering content, based on Minimo

engimo's Issues

security vulnerability

Hello,

I'm using engimo and have the following report from github

"""
We found a potential security vulnerability in one of your dependencies.
A dependency defined in …/engimo/package-lock.json has known security vulnerabilities and should be updated.
"""

Without going into more detail, could you look into it and hopefully update the insecure dependency?

Rmd support?

Hi,
I am wondering if R markdown is supported in this theme?

Thanks

`npm run build` removes needed scripts

javascript files for various widgets (like asciinema, mermaid etc) are only kept in static/assets/js.

But the default build command (NODE_ENV=production webpack) first deletes everything from that folder, so those widgets don't work anymore afterwards.

---

these are deleted as of 97989c2:

deleted:    static/assets/js/Chart.js
deleted:    static/assets/js/WaveDrom.js
deleted:    static/assets/js/asciinema-player.js
deleted:    static/assets/js/flowchart-latest.js
deleted:    static/assets/js/mermaid.min.js
deleted:    static/assets/js/narrow.js
deleted:    static/assets/js/raphael.min.js
deleted:    static/assets/js/sequence-diagram-min.js
deleted:    static/assets/js/snap.svg-min.js
deleted:    static/assets/js/underscore-min.js
deleted:    static/assets/js/viz.js
deleted:    static/assets/js/viz.render.js
deleted:    static/assets/js/webfont.js

Deprecated pages do not work

I tried adding deprecated: true to the front matter of a page but this doesn't seem to do anything. I also searched the template code for this, but I couldn't find any occurrence of deprecated there either. Is this feature still there and supported?

Demo is broken on the Hugo Themes website

Hello @achary

Your 3 commits from the 24th of October have broken your theme and the demo no longer generates on the Hugo Themes showcase.

Below is the ERROR log.

9:43:32 PM:  ==== PROCESSING  engimo  ======
9:43:32 PM: Building site for theme engimo using default content to ../themeSite/static/theme/engimo/
9:43:32 PM: ERROR 2019/11/16 19:43:32 failed to load data: failed to load data: "/opt/build/repo/_script/hugoThemeSite/exampleSite2/data/config/widgets.toml:13:1": unmarshal failed: Near line 13 (last key parsed ''): Key 'breadcrumbs' has already been defined.
9:43:32 PM: ERROR 2019/11/16 19:43:32 failed to load data: failed to load data: "/opt/build/repo/_script/hugoThemeSite/exampleSite2/data/config/widgets.toml:13:1": unmarshal failed: Near line 13 (last key parsed ''): Key 'breadcrumbs' has already been defined.
9:43:32 PM: ERROR 2019/11/16 19:43:32 failed to load data: failed to load data: "/opt/build/repo/_script/hugoThemeSite/exampleSite2/data/config/widgets.toml:13:1": unmarshal failed: Near line 13 (last key parsed ''): Key 'breadcrumbs' has already been defined.
9:43:32 PM: ERROR 2019/11/16 19:43:32 failed to load data: failed to load data: "/opt/build/repo/_script/hugoThemeSite/exampleSite2/data/config/widgets.toml:13:1": unmarshal failed: Near line 13 (last key parsed ''): Key 'breadcrumbs' has already been defined.
9:43:32 PM: ERROR 2019/11/16 19:43:32 render of "taxonomyTerm" failed: "/opt/build/repo/engimo/layouts/_default/terms.html:4:19": execute of template failed: template: _default/terms.html:1:3: executing "_default/terms.html" at <partial "header" .>: error calling partial: "/opt/build/repo/engimo/layouts/partials/header.html:4:19": execute of template failed: template: partials/header.html:10:8: executing "partials/header.html" at <partial "sidebar/sidebar" .>: error calling partial: "/opt/build/repo/engimo/layouts/partials/sidebar/sidebar.html:4:19": execute of template failed: template: partials/sidebar/sidebar.html:10:6: executing "partials/sidebar/sidebar.html" at <partial "extras/widget_area" (dict "Widgets" $sidebarWidgets "Scope" .)>: error calling partial: "/opt/build/repo/engimo/layouts/partials/extras/widget_area.html:4:19": execute of template failed: template: partials/extras/widget_area.html:7:8: executing "partials/extras/widget_area.html" at <partial (print "widgets/" .) $.Scope>: error calling partial: "/opt/build/repo/engimo/layouts/partials/widgets/about.html:4:19": execute of template failed: template: partials/widgets/about.html:4:19: executing "partials/widgets/about.html" at <index $configData $lang>: error calling index: index of untyped nil
9:43:32 PM: ERROR 2019/11/16 19:43:32 render of "taxonomy" failed: "/opt/build/repo/engimo/layouts/_default/list.html:4:19": execute of template failed: template: _default/list.html:1:3: executing "_default/list.html" at <partial "header" .>: error calling partial: "/opt/build/repo/engimo/layouts/partials/header.html:4:19": execute of template failed: template: partials/header.html:10:8: executing "partials/header.html" at <partial "sidebar/sidebar" .>: error calling partial: "/opt/build/repo/engimo/layouts/partials/sidebar/sidebar.html:4:19": execute of template failed: template: partials/sidebar/sidebar.html:10:6: executing "partials/sidebar/sidebar.html" at <partial "extras/widget_area" (dict "Widgets" $sidebarWidgets "Scope" .)>: error calling partial: "/opt/build/repo/engimo/layouts/partials/extras/widget_area.html:4:19": execute of template failed: template: partials/extras/widget_area.html:7:8: executing "partials/extras/widget_area.html" at <partial (print "widgets/" .) $.Scope>: error calling partial: "/opt/build/repo/engimo/layouts/partials/widgets/about.html:4:19": execute of template failed: template: partials/widgets/about.html:4:19: executing "partials/widgets/about.html" at <index $configData $lang>: error calling index: index of untyped nil
9:43:32 PM: ERROR 2019/11/16 19:43:32 render of "taxonomyTerm" failed: "/opt/build/repo/engimo/layouts/_default/terms.html:4:19": execute of template failed: template: _default/terms.html:1:3: executing "_default/terms.html" at <partial "header" .>: error calling partial: "/opt/build/repo/engimo/layouts/partials/header.html:4:19": execute of template failed: template: partials/header.html:10:8: executing "partials/header.html" at <partial "sidebar/sidebar" .>: error calling partial: "/opt/build/repo/engimo/layouts/partials/sidebar/sidebar.html:4:19": execute of template failed: template: partials/sidebar/sidebar.html:10:6: executing "partials/sidebar/sidebar.html" at <partial "extras/widget_area" (dict "Widgets" $sidebarWidgets "Scope" .)>: error calling partial: "/opt/build/repo/engimo/layouts/partials/extras/widget_area.html:4:19": execute of template failed: template: partials/extras/widget_area.html:7:8: executing "partials/extras/widget_area.html" at <partial (print "widgets/" .) $.Scope>: error calling partial: "/opt/build/repo/engimo/layouts/partials/widgets/about.html:4:19": execute of template failed: template: partials/widgets/about.html:4:19: executing "partials/widgets/about.html" at <index $configData $lang>: error calling index: index of untyped nil
9:43:32 PM: ERROR 2019/11/16 19:43:32 render of "section" failed: "/opt/build/repo/engimo/layouts/_default/list.html:4:19": execute of template failed: template: _default/list.html:1:3: executing "_default/list.html" at <partial "header" .>: error calling partial: "/opt/build/repo/engimo/layouts/partials/header.html:4:19": execute of template failed: template: partials/header.html:10:8: executing "partials/header.html" at <partial "sidebar/sidebar" .>: error calling partial: "/opt/build/repo/engimo/layouts/partials/sidebar/sidebar.html:4:19": execute of template failed: template: partials/sidebar/sidebar.html:10:6: executing "partials/sidebar/sidebar.html" at <partial "extras/widget_area" (dict "Widgets" $sidebarWidgets "Scope" .)>: error calling partial: "/opt/build/repo/engimo/layouts/partials/extras/widget_area.html:4:19": execute of template failed: template: partials/extras/widget_area.html:7:8: executing "partials/extras/widget_area.html" at <partial (print "widgets/" .) $.Scope>: error calling partial: "/opt/build/repo/engimo/layouts/partials/widgets/about.html:4:19": execute of template failed: template: partials/widgets/about.html:4:19: executing "partials/widgets/about.html" at <index $configData $lang>: error calling index: index of untyped nil
9:43:32 PM: Error: Error building site: failed to load data: failed to load data: "/opt/build/repo/_script/hugoThemeSite/exampleSite2/data/config/widgets.toml:13:1": unmarshal failed: Near line 13 (last key parsed ''): Key 'breadcrumbs' has already been defined.
9:43:32 PM: FAILED to create exampleSite for engimo

You need to look into it.

Also note that if I execute git reset --hard HEAD~3 to undo the last 3 commits so that the
HEAD is now at 16fdd55 Fixing support for mathjax

Then your theme's demo generates again.

Setting `hideMainMenu = true` in config.toml causes the sidebar-toggler (on narrow-width screens) to be on the rightside of the screen

Great package, still getting my hands dirty with it.

I'm new to Hugo, but I noticed when I set hideMainMenu to true, the sidebar toggler (hamburger icon) that's visible on narrow-width screens get stuck on the right. An effective workaround is to simply delete all menu.main items in the config, and set hideMainMenu to false. This way, no main menu is displayed, and the sidbar-toggler remains on the left where it belongs.