acmlira/mimicry

A simple crossplatform SDL2 + skia CMake build environment example/test

mimicry's Issues

python3 support

feature request 🙏

No type named MakeGL in GrDirectContext (or GrContext)

Android SDK	NDK	CMake	skia	SDL
30	21	10	chrome/m87	2.0.12

During the compilation of the application I realized that GrDirectContext and GrContext hasn't type named MakeGL. The skia build flags were these:

skia_use_system_libjpeg_turbo = false
skia_use_system_libwebp = false
skia_use_system_expat = false
skia_use_system_libpng = false
skia_use_system_freetype2 = false
ndk="/home/allan/Android/Sdk/ndk/21.3.6528147"
target_os="android" 
target_cpu="arm"
is_debug=false
is_component_build=true
extra_cflags=["-O3"]
skia_use_angle = false
skia_use_icu = false
skia_use_lua = false
skia_use_opencl = false
skia_use_piex = false
skia_use_zlib = false
skia_enable_tools = false
skia_enable_pdf = false
skia_use_gl = true
skia_enable_skottie = false

This was the error log:

../../../../../../../../sources/main.cpp:203:55: error: no type named 'MakeGL' in 'GrDirectContext'
      sk_sp<GrDirectContext> grContext(GrDirectContext::MakeGL(interface));
                                       ~~~~~~~~~~~~~~~~~^
../../../../../../../../sources/main.cpp:203:37: warning: parentheses were disambiguated as a function declaration [-Wvexing-parse]
      sk_sp<GrDirectContext> grContext(GrDirectContext::MakeGL(interface));
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../../../../../../sources/main.cpp:203:38: note: add a pair of parentheses to declare a variable
      sk_sp<GrDirectContext> grContext(GrDirectContext::MakeGL(interface));
                                       ^
                                       (
1 warning and 1 error generated.
[2/49] Building CXX object externals/skia/out/cmake/CMakeFiles/skia.dir/__/__/src/core/SkDeferredDisplayList.cpp.o

Let's see the skia code snippet:

#ifdef SK_GL
    /**
     * Creates a GrDirectContext for a backend context. If no GrGLInterface is provided then the
     * result of GrGLMakeNativeInterface() is used if it succeeds.
     */
    static sk_sp<GrDirectContext> MakeGL(sk_sp<const GrGLInterface>, const GrContextOptions&);
    static sk_sp<GrDirectContext> MakeGL(sk_sp<const GrGLInterface>);
    static sk_sp<GrDirectContext> MakeGL(const GrContextOptions&);
    static sk_sp<GrDirectContext> MakeGL();
#endif

Apparently the SK_GL flag is not being set correctly. My workaround was just adding -DCMAKE_CXX_FLAGS="-DSK_GL" to my build script.

Undefined reference to AHardwareBuffer

Android SDK	NDK	CMake	skia	SDL
30	21	10	chrome/m87	2.0.12

I had some problems when compiling skia with Android SDK 30. These were my build flags:

skia_use_system_libjpeg_turbo = false
skia_use_system_libwebp = false
skia_use_system_expat = false
skia_use_system_libpng = false
skia_use_system_freetype2 = false
ndk="/home/allan/Android/Sdk/ndk/21.3.6528147"
target_os="android" 
target_cpu="arm"
is_debug=false
is_component_build=true
extra_cflags=["-O3"]
skia_use_angle = false
skia_use_icu = false
skia_use_lua = false
skia_use_opencl = false
skia_use_piex = false
skia_use_zlib = false
skia_enable_tools = false
skia_enable_pdf = false
skia_use_gl = true
skia_enable_skottie = false

This was the error log:

../../../../../../../../externals/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:53: error: undefined reference to 'AHardwareBuffer_describe'
../../../../../../../../externals/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:74: error: undefined reference to 'AHardwareBuffer_acquire'
../../../../../../../../externals/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:78: error: undefined reference to 'AHardwareBuffer_release'
../../../../../../../../externals/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:78: error: undefined reference to 'AHardwareBuffer_release'
../../../../../../../../externals/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:117: error: undefined reference to 'AHardwareBuffer_acquire'
../../../../../../../../externals/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:125: error: undefined reference to 'AHardwareBuffer_release'
../../../../../../../../externals/skia/src/gpu/GrAHardwareBufferImageGenerator.cpp:125: error: undefined reference to 'AHardwareBuffer_release'
../../../../../../../../externals/skia/src/image/SkImage_Gpu.cpp:668: error: undefined reference to 'AHardwareBuffer_describe'
../../../../../../../../externals/skia/src/image/SkSurface_Gpu.cpp:700: error: undefined reference to 'AHardwareBuffer_describe'

clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

These errors are generated by the AHardwareBuffer class I didn't find skia build arguments that solve this and as this is only compiled with versions greater than 26 of the Android API, backing down the version was also not possible since the SDL requires that the API be greater than 26 to fit as well. I had to change the source code of skia to compile. For each file mentioned in the log I had to change the following line:

#if defined(SK_BUILD_FOR_ANDROID) && __ANDROID_API__ >= 26

to:

#if defined(SK_BUILD_FOR_ANDROID) && __ANDROID_API__ > 30

This solves the problem but is not ideal

link in "preparing skia" section is dead

Preparing skia
The standard skia build does not have CMake compatibility so we will transform the build. Learn more about the skia build.

i think it should point to https://skia.org/docs/user/build/ ?