acristescu/onlinego

Repo for the OnlineGo Android app.

onlinego's Issues

Inconsistent ranks

Unless I'm reading something wrongly, there seems to be an issue with the ranks in the latest beta.

See two attached images.

Show "user is online" indicator inside a game

A nice improvement would be to have the user card inside a game containing "user is online" indicator that OGS has:

[ Feature Request ] toggle to hide opponent ranks in Settings

Hi all, I use OGS' option to hide opponent ranks. Might it not be too much trouble to add a toggle in Settings that would omit the _k / _d output on the games list? Thank you for your consideration!

Finished game not appearing in "finished" list

Hello
The recent game I won against user Kanga (currently the most recently finished game in
https://online-go.com/user/view/287410 ) disappeared from OnlineGo app - it's the first time I see it happen, any idea what could have happened here?

Moderator chat

Moderators have a modal chat tool on the website that they can use to communicate warnings and other important messages to the user and make sure that they are heard. The app does not support it. The websocket packet looks like this:

"private-superchat"
{
enable: false
moderator_id: 412892
moderator_username: "Eugene"
player_id: 89194
player_username: "MrAlex"
}

Declare application as open source

Maybe it goes in the About app in the Setting tab.

Not mandatory, but had I known the app was open source earlier, I would have contributed sooner.

New navigation

Bottom bar should have:

• play
• learn
• stats
• settings

Tutorial

Losing network connectivity in some cases causes a crash

Better stone removal UI

[Feature Request] Support conditional moves

I absolutely love your app and use it every day. Now that you've added score estimates, the only thing that occasionally pulls me back to the website is to log conditional moves. I would love to see those in the app!

App crashes in many interesting ways on Android 4.4 - maybe drop support?

Identified issues:

• sometimes crashes because of multidex limit
• vector images keep causing problems
• padding on CardViews is broken

At the moment we have 12 users on this version (out of 400+). Maybe drop support?

Forum announcement

I think it would be nice to make a post announcement of the client on the OGS forum: https://forums.online-go.com/

I know the app is already being discussed in some threads there but those are general android client threads with a lot of posts without a good visibility for the project.

The post should highlight the Android Store URL and the Github URL. It should also highlight the current features of the app as well as the ones in development and welcome anyone to report bugs or contribute to the code.

You could also ping the OGS developer to know if they want to advertise it on their website.

I can write the post if you want.

ping @acristescu

Landscape orientation

Especially so for tablet layouts, landscape orientation would be great for more than the login screen.

I wonder if there would be added complexity in the state preservation/restoration when rotating with a game on screen, especially so if they were in analysis mode.

[Feature request] Settings > Notification controls by time of day

As discussed in here, dev has plans on making an "Settings" screen.

I believe it would be nice to be able to control what sort of notifications does the application produce and when. For example, it might be useful to block notifications overnight or while being at work. Or maybe just enable them for specific hours?

Learn page

With stuff such as:

• tutorial
• spectate
• game database
• tsumego

Support for paused timers

Stats page

Stats and game history

Ability to open a game in the browser

Hi Alex, having a way to open the game in the browser would be useful.
Was it a choice not to do it? Given the gap between app and website functionality (conditional moves, Malkovich comments, etc..), I think it would make total sense, at least for the time being.

As an example, if you're familiar with BW-Go and its plugin to play correspondence games on DGS, a similar "browse to game" option in the contextual menu would suffice. I can do a PR with it if you're OK.

Integrate an in-app database of games

Integrate something such as https://github.com/yenw/computer-go-dataset into the app

Feature request: Poll Now, please

Hi, low prio Feature Request for bad networking environment, also useful right after a change to/from a bad wifi: poll the game status immediately after manual trigger.
A nice trigger would be touch-clicking the upper right online-go icon, where the number of games with your turn is displayed. Give a minimal feedback; a rotating icon or something similar, at trigger happened until success or failure of the poll (or app is sent to background, of course).
Thanks

SGF Download of a game

Simulate moves on an earlier state of the game

We can actually simulate moves, but when we go back on history and start to simulate moves from this old state, it brings us to the last state of the game.

I wish to be able to see if an alternative would have been better that what I actually have played.

Settings page

Notification customisation?

Game chat

Support "Undo last move"

On the website you're able to undo a move
this results in a question to the opponent, stating that the other player has requested an undo of the last move. Which you can accept.
If you choose not to accept you can just do your next move (thus declining the request)

The app doesn't have the "undo" button.
But (perhaps more important): it doesn't support the "accept undo request" option (nor inform you on it).

Rationale:
As a result a player can feel offended: if a (novice) friend is using the undo button on a regular basis it seems like I'm ignoring him all the time. But I'm not even aware he's requesting undos!

Options:

• implement entire "undo last move" user story
  if that's too much:
• show "Accept undo last move request"
  or
• automated text in the chat stating that user A has requested an undo but user B is using an app that doesn't support this feature. "If needed you can accept the undo on the full site version at online-go.com" or something like that.

App confusingly reports you winning when you in fact lost

Noticed while playing a live game that the app said I won although I have lost by 0.5 points. After the fact the game does indeed report me losing, it's just when the thing was live the dialog was wrong

Feedback for when opponent passed

Client ignores the "disable analysis" flag

Throw notification for new message from opponent in game

The polling system for notifying me about challenges and active games is very useful. It would be nice to also incorporate new messages in game into a notification.

Here's the use case I have in mind: I play a several correspondence games with club mates. The games are slow and occasionally have discussion. They're (unranked) teaching games, essentially. At any rate, my opponent may be asking a question or linking an analysis. They may be waiting on my response before playing their turn. Since I'm not expecting the message, I may not check the game for some time. It would be nice to get a notification.

There may be some risk with spam, so this feature may have to be coupled with some granular notification preferences, perhaps even on a per-game or per-user basis.

[Bug] Title bar text doesn't update after leaving game

Upon opening the application, the title bar name is set to "OnlineGo, alpha_b59".
When you enter a game this changes to the two opponents and the person who is to play.

Going back to the main screen, the text remains that of the opponents, even if you change to "spectate" or "challenges". Turning screen on or off resets the text.

Dark Theme

I would like a dark/night theme like on web page. Light text on a dark/black background. Not exactly an issue. More of a wish. :-)

OGS API error after opening app

Since, I think, the update before last, the app is showing an API error every time you open the app.

Text overlaps on the game screen when the screen ratio is < 16:9 (e.g. Samsung J1)

User image appears on top of placeholder sometimes

[Feature request] show new chat message in home screen

Sometimes your opponent hasn't made a move (so it's not your turn yet), but he has made a remark in the chat.

At the moment you need to enter the game to see if there's a new message in chat. Might be practical to show new messages in the home screen.

Just a quick mock up as a suggestion:

Home screen lags when a lot of games have been played

Sometimes my screen freeze a little when I am on home page and a game is moving. All last played games boxes are also moving, and sometimes freezes my screen.

Maybe it should be paged / paginated (not sure how to write it)

Display counters for games in "your turn" and "opponents turn"

Today we know how many moves we have to play through the top-right icon, still for Opponents turn (the rest of the games we have ongoing), we have to scroll down and count each bar to understand how many are there.

Adding a simple counter under parenthesis in the "your turn" and "opponent's turn" would do the trick, something similar to what BW-Go has:

Analysis mode

Issues with time left info

For some games, the time left information is wrong, both in the games list view and in the game view. See attached screenshots:

The games are:
https://online-go.com/game/15872226
https://online-go.com/game/15910341

Also, for game #15872226 the counter is continuously decreasing in the game view.

[Feature Request] Board coordinates

Either an option, or overlay when the board border is long pressed? Space is tight I know 😟

Jumping out to the website anytime somebody tells you about that move on Q12 (or you want to say something) isn't nice. Maybe by practice it will get more easy after getting better at the game 😆

Search for game redisign

Contributing assistance

Hello!

I'm trying to get this project up and running so I can contribute to the project and tackle some tasks, but out of the box Gradle sync and building both have issues. Would you kindly introduce a write up on how an individual without your google-services.json, etc. can contribute to this project?

Warn user when time is about to run out in a live game

Building OnlineGo

Hello,

I am trying to build the app with Android Studio (latest version) but the build fails here : https://github.com/hadim/OnlineGo/blob/053f2af7f3221ee60a2df612a2a6c64b58caae1d/app/build.gradle#L55

The build needs the env variable SECRET_KEY to be set. I don't understand what the generateGoogleJson is exactly doing. Any chance we can build the app without it?

ping @acristescu

Support for open challenges

Hi Alex,
For game creation, today the app supports

• "Automatch" (equivalent to the "quick match" of the website)
• "Custom" (where you can target a specific user - equivalent to Challenging someone on the website)

It lacks the 3rd option, which I believe is the most used (certainly the one I use the most): the possibility to issue open challenges with custom settings (equivalent to the Custom/Create feature )

I started looking into this while submitting pr #58 , but wanted to check with you for the approach:
-> what about having a 3rd button for this? we would have

• "Automatch" (unchanged)
• "Challenge" (renaming the "Custom")
• "Custom" (new button)

"Custom" would be a mix of the two others - a settings picker similar to Challenge, but a subscription model and "open challenge" card view similar to the ones after submitting an Automatch.

[Feature request] Zoomable board

Small screens, big fingers... a zoomable board would be good.
I think a continuous zoom wouldn't even be necessary, just jump to 13x13 and 9x9 size (maybe also 5x5 for tiny screens?). If that is easier to implement pan by whole stone sizes (no continuous pan). And maybe add a ragged board edge for signaling where there are other parts of the board, but that probably isn't needed anyway.
A board overview/map probably isn't needed, since the available area is tight anyway. Or put the map (or even just a static lens symbol) over your player picture left above or below the map?

Pressing the "your move" button should cycle through all the games in which it is your turn

Better finished game UI

[Feature request] Jump 10 moves at a time and at beginning/end of game

Now that we can see past games and go through the moves, it would be really useful to have an option to move more moves back and ahead, rather than the one move jump.

This can perhaps be done with additional buttons, or by long pressing/double taping the existing arrow buttons (so as not to have too many buttons).